DirectionType allowed in LineInDirectionRef structure#1017
Closed
DirectionType allowed in LineInDirectionRef structure#1017
Conversation
ue71603
requested review from
Aurige,
JohanEntur,
TuThoThai,
duexw,
thbar and
trurlurl
ue71603
added
the
enhancement
Contributor
|
It contains refs, why do you want to have this container to be an enumeration? |
Contributor
Author
|
We will remove Direction from our profile. We only have two Direction inbound and outbound (and many others have this too). Using Direction to remodel what DirectionType does is not really useful. And as it was mentioned. In JourneyPattern this exact behaviour is also modeled that way. |
Contributor
|
And the meaning is now: this interchange applies to all ServiceJourneys with Line+DirectionType or ServiceJourneys with ServiceJourneyPattern+LineRef+DirectionType? |
Contributor
Author
|
I think different combinations are reasonable:
|
Collaborator
|
@ue71603, should not this one target branch |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In JourneyPattern DirectionType is allowed instead of Direction. This was not done in LineInDirection. We believe that this harmonisation is needed.