fix(benchmarks): remove hooks via HookPoint instead of bogus add_hook handle#1426
Open
danra wants to merge 1 commit into
Open
fix(benchmarks): remove hooks via HookPoint instead of bogus add_hook handle#1426danra wants to merge 1 commit into
danra wants to merge 1 commit into
Conversation
… handle HookPoint.add_hook returns None, but the benchmark helpers stored its return value as a "handle" (silencing mypy with behind an `if handle is not None` guard). Since the value was always None, the guard was always false and the capture hooks were never removed. Track the HookPoint that was registered on and clean up via hook_point.remove_hooks() (dir="bwd" for backward hooks), matching the existing idiom in TransformerBridge.run_with_cache. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
danra
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
HookPoint.add_hookreturnsNone, but the benchmark helpers stored its return value as a "handle" (silencing mypy with behind anif handle is not Noneguard). Since the value was alwaysNone, the guard was always false and the capture hooks were never removed.Track the
HookPointthat was registered on and clean up viahook_point.remove_hooks()(dir="bwd"for backward hooks), matching the existing idiom inTransformerBridge.run_with_cache.Type of change
Checklist: