Skip to content

Add Olmo3 architecture adapter tests#1412

Merged
jlarson4 merged 1 commit into
TransformerLensOrg:devfrom
RecreationalMath:olmo3-adapter-test
Jun 22, 2026
Merged

Add Olmo3 architecture adapter tests#1412
jlarson4 merged 1 commit into
TransformerLensOrg:devfrom
RecreationalMath:olmo3-adapter-test

Conversation

@RecreationalMath

Copy link
Copy Markdown
Contributor

Description

Adds the minimal unit test for Olmo3ArchitectureAdapter under tests/unit/model_bridge/supported_architectures/.

The adapter body is pass. It inherits its config, component mapping, and weight conversions unchanged from Olmo2ArchitectureAdapter (covered by test_olmo2_adapter.py). Per the unit-test guide ("for a pure-pass subclass adapter… the subclass needs exactly one test, that it is a subclass"), the only contract this subclass owns is the subclass relationship itself.

The single test asserts issubclass(Olmo3ArchitectureAdapter, Olmo2ArchitectureAdapter). Modeled on the existing test_llava_next_adapter.py precedent.

Contributes to #1302 (Olmo3 checkbox).

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have not rewritten tests relating to key interfaces which would affect backward compatibility

@jlarson4 jlarson4 merged commit 377fd95 into TransformerLensOrg:dev Jun 22, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants