Direct path patch demo#1398
Conversation
|
Hi @danra! Thanks for putting this together. I do want to keep your demo as part of the Exploratory Analysis demo as well as @mukund1985's specific methods & unit testing. There are things both of you have done well that I want to make sure are included in TransformerLens. My intention is to merge #1396 first, and have you rebase to the latest version of |
|
@jlarson4 That wouldn't match the existing structure of the demos: Exploratory Analysis demonstrates the conceptual activation patching technique, showing how to do it from scratch. It makes a point of not using the existing utilities, and instead refers to the Activation Patching one for that purpose:
Consistent with that approach, I would keep Exploratory Analysis demonstrating direct path patching from first-principles, and add a similar reference to a demo for using library's facilities. That could be a new section in the existing notebook (which could change its name from "Activation Patching" to "Patching Models", or some other, wider-scope name) or a new notebook (which #1396 already has). |
|
You are absolutely correct @danra. I was looking at your edits in isolation and not thinking about what exploratory analysis actually is. I am rerunning the CI tests that failed due to 492s, assuming those pass I will get this merged. Thank you for your feedback, I appreciate it! |
Description
Adds direct path patching demonstration to the Exploratory Analysis notebook, resolving #111
(as it so happens, an additional PR #1396 had just been opened to add direct path patching to transformer_lens - apparently I was not the only one working on this! The other PR adds a new demo rather than amending the existing Exploratory Analysis one, and adds the feature to
transformer_lens. I think my approach of amending the existing notebook demonstrates the technique better.)Type of change
Please delete options that are not relevant.
Checklist: