fix: CcxtBroker OKX/Bybit initialization and market fetching#120
Open
HengWeiBin wants to merge 7 commits intoTraderAlice:devfrom
Open
fix: CcxtBroker OKX/Bybit initialization and market fetching#120HengWeiBin wants to merge 7 commits intoTraderAlice:devfrom
HengWeiBin wants to merge 7 commits intoTraderAlice:devfrom
Conversation
added 5 commits
April 18, 2026 19:58
- Pass 'type' in params to fetchMarkets() to fix 'Parameter instType error' on OKX - Add safety checks for enableDemoTrading() to prevent 'undefined (reading rest)' crash - Map 'sandbox' mode to enableDemoTrading() for OKX and Bybit - Ensure sandbox and demoTrading options are applied correctly without conflict
…to prevent DataCloneError
…uble-click issue - Moved CooldownGuard state update from check() to new onSuccess() hook - Added isPushing lock to TradingGit to prevent overlapping pushes - Updated Telegram plugin to show 'Processing...' state during push - Fixed missing 'sandbox' property in CcxtBroker tests - Added Decimal import in trading tools
e7db2df to
bdf8c75
Compare
added 2 commits
April 19, 2026 10:44
…tDetails
- Add resolveContract helper to UnifiedTradingAccount to auto-fill broker-native fields (conId, localSymbol) from aliceId
- Update getQuote and getContractDetails to use resolveContract, fixing resolution issues for brokers like CCXT
- Update CCXT broker/contract comments to reflect correct aliceId format "{utaId}|{nativeKey}"
- Fix type errors in trading.spec.ts (position cost/price fields must be strings)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes several CCXT initialization issues specifically affecting OKX and Bybit.
Changes