Skip to content

Disable blocking_read_window behind its filed defect - #577

Closed
Japabu wants to merge 1 commit into
mainfrom
wt/toyos-brwred
Closed

Japabu wants to merge 1 commit into
mainfrom
wt/toyos-brwred

Conversation

@Japabu

@Japabu Japabu commented Sep 28, 2026

Copy link
Copy Markdown
Collaborator

Summary

Test plan

  • cargo test --lib — EXIT=0 (384 passed, 0 failed, 1 ignored)
  • cargo test --test toyos-build -- --list — EXIT=0
  • cargo run -- --known-red blocking_read_window — YES, disabled

🤖 Generated with Claude Code

The orchestrator's Fast tier and nightly for PR #536 at 5235eda hit the same
verdict twice, and the round-13 reviewer found the PR leaves the wake and pipe
path alone while the two ends spent about 1580 ms of CPU each — consistent
with the actuator's 50 ms holds running out, not a lost wake. The issue's
verdict also rests on a 3 s duration inside a QEMU test, which the owner rules
is metal-only; PR #562 is removing such verdicts. A flaky test is disabled at
once, never re-run.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01W6rME2DoqwjcYFStYHHY4j
@Japabu
Japabu marked this pull request as ready for review September 28, 2026 12:13
@Japabu

Japabu commented Sep 28, 2026

Copy link
Copy Markdown
Collaborator Author

Review of #577 at c0a000eb.

CI host run 36420477617: success at c0a000eb. The PR is not a draft. The host gates were re-run in the worktree: cargo test --lib EXIT=0 (384 passed, 1 ignored). cargo test --test toyos-build -- --list EXIT=0, and it prints [toyos] disabled: blocking_read_window. cargo run -- --known-red blocking_read_window EXIT=0 and prints YES, disabled. Net +15 −1: the issue +10 −1, the redlist row +4, production 0.

BLOCKER

NOTE

  • issues/build/blocking-read-window-reds-beside-other-guests.md:3 — kind: finding was reviewed here and still owns a disabled test. issues/README.md says a finding is promoted to defect or folded at its next review, so promote it.
  • issues/build/blocking-read-window-reds-beside-other-guests.md — no owner is named for the disable. CLAUDE.md asks for ownership, evidence and an exit.
  • tests/toyos.rs:11478 — this is the only guest arm that stages a post between the condition read and the park. blocking_read_stress on the shared boot (tests/toyos.rs:489) runs without the window, and loom_watch checks the model on the host only. While the test is disabled, the notified-bit commit has no guest negative control, and watch.rs's window module, toyos-sched HELD/STEP and window_held have no reader that runs.
  • src/redlist.rs:28 — No QEMU test measures time, and audio is judged on metal only #562 keeps blocking_read_window enabled and rewrites its verdict. Whichever of the two lands second must settle this row, or the test stays off after No QEMU test measures time, and audio is judged on metal only #562.

REMOVE

SEND BACK

@Japabu

Japabu commented Sep 28, 2026

Copy link
Copy Markdown
Collaborator Author

Closed without landing. A same-session A/B (orchestrator, 2026-09-28): blocking_read_window went red 2 of 10 on PR #536's head 06c6195 and 0 of 10 on main cd2e630, interleaved; with the earlier 2 of 2 on #536 and 32 of 32 green off #536, the red is #536's regression, not main's flake. It goes back to #536.

@Japabu Japabu closed this Sep 28, 2026
@Japabu
Japabu deleted the wt/toyos-brwred branch September 29, 2026 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant