Conversation
The orchestrator's Fast tier and nightly for PR #536 at 5235eda hit the same verdict twice, and the round-13 reviewer found the PR leaves the wake and pipe path alone while the two ends spent about 1580 ms of CPU each — consistent with the actuator's 50 ms holds running out, not a lost wake. The issue's verdict also rests on a 3 s duration inside a QEMU test, which the owner rules is metal-only; PR #562 is removing such verdicts. A flaky test is disabled at once, never re-run. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W6rME2DoqwjcYFStYHHY4j
Japabu
marked this pull request as ready for review
September 28, 2026 12:13
Collaborator
Author
|
Review of #577 at CI BLOCKER
NOTE
REMOVE
SEND BACK |
Collaborator
Author
|
Closed without landing. A same-session A/B (orchestrator, 2026-09-28): blocking_read_window went red 2 of 10 on PR #536's head 06c6195 and 0 of 10 on main cd2e630, interleaved; with the earlier 2 of 2 on #536 and 32 of 32 green off #536, the red is #536's regression, not main's flake. It goes back to #536. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
blocking_read_windowreds beside other guests on host load, naming a lostwake a slow guest also satisfies
(
issues/build/blocking-read-window-reds-beside-other-guests.md). Theorchestrator's Fast tier and nightly for PR Storage: file servers for DATA, the log and the boot volume; the kernel's NVMe and FAT go #536 at
5235eda7hit ittwice, 2 of 2 red, and the round-13 reviewer found Storage: file servers for DATA, the log and the boot volume; the kernel's NVMe and FAT go #536 leaves the wake and
pipe path alone, with the two ends spending about 1580 ms of CPU each —
consistent with the actuator's 50 ms holds running out rather than a lost
wake.
blocking_read_windowinsrc/redlist.rsbehind the existing issue, setsits status to
expected-red, and adds the new evidence lines plus a notethat its verdict rests on a 3 s duration inside a QEMU test, which the
owner rules is metal-only — PR No QEMU test measures time, and audio is judged on metal only #562 is removing such verdicts.
Test plan
cargo test --lib— EXIT=0 (384 passed, 0 failed, 1 ignored)cargo test --test toyos-build -- --list— EXIT=0cargo run -- --known-red blocking_read_window—YES, disabled🤖 Generated with Claude Code