Disable log_ring_keeps_the_owners_slots behind its filed defect - #569
Conversation
issues/kernel/a-log-rings-owner-is-named-only-when-logd-reads-its-registration.md already recorded 2 red of 13 on origin/main, each red the same failure. The orchestrator's Fast-tier run of PR #563 at d6716fc on 2026-09-28 hit it again: /log carried no "===TEST_END test_rs_log_flood exit=0===" because the child's flood took the ring's slots the parent's own line needed (1917 flood lines in /log). A flaky test is disabled at once, never re-run. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W6rME2DoqwjcYFStYHHY4j
|
Review of #569 at Gates at this head: CI run 36392812754 ( Size: +6 −1, all of it a redlist row and issue lines. No production code and no tests. Checked with no finding:
BLOCKER NOTE
REMOVE
LAND AFTER NAMED CHANGES |
…ons note, cut a scratchpad log name The disable's issue named no holder; it now reads "Owner: `toyos/src/log/region.rs`'s `Ring::push`; held by the orchestrator", matching the sibling expected-red issues' form. Its Exit line folds in the reviewer's finding that no test exercises the owner decision today: `let keep = 0;` in `Ring::push` or a deleted `ring.own(pid)` each pass every test in the tree, so the exit's test must turn both mutations red. Drops a scratchpad log name that resolves nowhere on main, a redundant date and a sentence the row and `status: expected-red` already say, in the issue and in the PR body. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W6rME2DoqwjcYFStYHHY4j
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W6rME2DoqwjcYFStYHHY4j
Brings #569 (log_ring_keeps_the_owners_slots on the redlist); no conflict. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W6rME2DoqwjcYFStYHHY4j
Takes #560, #541, #565, #563, #569 and #570. `src/ci.rs` and `tests/toyos.rs` merge without conflict; `rust` takes main's pin, 1b236638, since this branch carries no fork commit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W6rME2DoqwjcYFStYHHY4j
Summary
log_ring_keeps_the_owners_slotsinsrc/redlist.rsbehind its filed defect,issues/kernel/a-log-rings-owner-is-named-only-when-logd-reads-its-registration.md.origin/main, each red the same signature. The orchestrator's Fast-tier run of PR The kernel boots on QEMU's stock edk2, network included: the direct map ends at the last memory, every kernel root slot exists before the first user space, and a BAR's free run is a gap inside its width's space #563 atd6716fc7hit it again:/log carries no "===TEST_END test_rs_log_flood exit=0===": the child's flood took the slots its parent's line needed (1917 flood lines in /log). The project rule is that a flaky test is disabled at once, never re-run.statusmoves fromopentoexpected-red(required bysrc/redlist.rs's own gate) and gets one added line recording this new sighting and the row it now backs.toyos/src/log/region.rs'sRing::push; held by the orchestrator, matching the sibling expected-red issues' form) and its Exit line now names the two mutations —let keep = 0;inRing::push(toyos/src/log/region.rs:202) and a deletedring.own(pid)(userland/logd/src/origin.rs:176) — that the exit's test must turn red, since no test today exercises that owner decision. Drops a scratchpad log name, a redundant date and a sentence the row andstatus: expected-redalready say.Gates (host only — this agent never runs QEMU)
cargo test --lib: exit 0 (384 passed; 0 failed; 1 ignored) — includes the redlist-row check against the issue file.cargo test --test toyos-build -- --list: exit 0 — listslog_ring_keeps_the_owners_slotsand confirms it is disabled.cargo run -- --known-red log_ring_keeps_the_owners_slots: exit 0, answeredYES, disabled — it does not run.Not run here
No guest test, Fast tier or
cargo runlaunch — this is a redlist/issue-only change with no code under test; the orchestrator's own Fast-tier run of #563 is the evidence cited above, not reproduced by this agent.🤖 Generated with Claude Code