Skip to content

Conversation

@Totodore
Copy link
Owner

Motivation

Currently if there is some desync due to tokio being too busy or some other factor, the connect packet may not be sent because the engineio socket is already closed.
The previously inserted socket was not correctly removed in case of error.

Fixes #627

@Totodore Totodore added C-Bug Something isn't working A-socketioxide Area related to socketioxide labels Jan 24, 2026
@Totodore Totodore enabled auto-merge (squash) January 24, 2026 11:43
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 24, 2026

Merging this PR will not alter performance

✅ 87 untouched benchmarks


Comparing fix-close-socket-ns-fail (e8b61bd) with main (acc5cb0)

Open in CodSpeed

@Totodore Totodore merged commit 1814e90 into main Jan 24, 2026
19 checks passed
@Totodore Totodore deleted the fix-close-socket-ns-fail branch January 24, 2026 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-socketioxide Area related to socketioxide C-Bug Something isn't working

Projects

None yet

2 participants