Skip to content

ci: removed signing key logic from release workflow - #1071

Merged
TomerFi merged 1 commit into
devfrom
ci/remove-signing-key
Aug 26, 2026
Merged

ci: removed signing key logic from release workflow#1071
TomerFi merged 1 commit into
devfrom
ci/remove-signing-key

Conversation

@TomerFi

@TomerFi TomerFi commented Aug 26, 2026

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • Chores
    • Simplified the release process by removing unnecessary commit-signing setup.
    • Release automation continues without generating or configuring SSH signing credentials.

@sourcery-ai

sourcery-ai Bot commented Aug 26, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

The release workflow no longer provisions the SSH signing key or configures Git to sign commits, while the remaining release setup is unchanged.

File-Level Changes

Change Details Files
Remove SSH commit-signing setup from the release workflow.
  • Delete the step that writes the signing key from the secret to the runner temporary directory.
  • Remove Git configuration for SSH signing, the signing key, and automatic commit signing.
.github/workflows/release.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@TomerFi
TomerFi merged commit 87edb14 into dev Aug 26, 2026
7 of 8 checks passed
@snyk-io

snyk-io Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@TomerFi
TomerFi deleted the ci/remove-signing-key branch August 26, 2026 01:24

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Needs a human reviewer. Release-generated commits will no longer carry SSH signatures, so consumers or automation that rely on signed provenance may reject them or lose assurance that they came from the trusted workflow. Reverting restores signing for future runs, but commits created while signing was removed remain unsigned and would need to be recreated or otherwise repaired.


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 67a00df3-eb06-499c-afc2-5116c834b988

📥 Commits

Reviewing files that changed from the base of the PR and between adee668 and af6e90c.

📒 Files selected for processing (1)
  • .github/workflows/release.yml

Walkthrough

The release workflow removes SSH signing key creation and Git SSH commit-signing configuration.

Changes

Cohort / File(s) Summary
Release signing configuration
.github/workflows/release.yml
Removes the SSH signing key file creation and Git SSH commit-signing configuration.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/remove-signing-key

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Aug 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.07%. Comparing base (adee668) to head (af6e90c).
⚠️ Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1071   +/-   ##
=======================================
  Coverage   96.07%   96.07%           
=======================================
  Files           1        1           
  Lines         331      331           
=======================================
  Hits          318      318           
  Misses         13       13           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant