ci: removed signing key logic from release workflow - #1071
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThe release workflow no longer provisions the SSH signing key or configures Git to sign commits, while the remaining release setup is unchanged. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
There was a problem hiding this comment.
Hey - I've reviewed your changes and they look great!
Sourcery assessment
Needs a human reviewer. Release-generated commits will no longer carry SSH signatures, so consumers or automation that rely on signed provenance may reject them or lose assurance that they came from the trusted workflow. Reverting restores signing for future runs, but commits created while signing was removed remain unsigned and would need to be recreated or otherwise repaired.
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
WalkthroughThe release workflow removes SSH signing key creation and Git SSH commit-signing configuration. Changes
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #1071 +/- ##
=======================================
Coverage 96.07% 96.07%
=======================================
Files 1 1
Lines 331 331
=======================================
Hits 318 318
Misses 13 13 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Summary by CodeRabbit