Skip to content

docs(governance): 登记 AH-SR-052 auth fail-closed 默认 fail-open 风险 - #1745

Merged
DeliciousBuding merged 1 commit into
masterfrom
docs/auth-fail-closed-risk-register
Aug 17, 2026
Merged

docs(governance): 登记 AH-SR-052 auth fail-closed 默认 fail-open 风险#1745
DeliciousBuding merged 1 commit into
masterfrom
docs/auth-fail-closed-risk-register

Conversation

@DeliciousBuding

Copy link
Copy Markdown
Collaborator

背景

审计 P1-2:AuthFailClosedDefault = false 致 jti 黑名单 fail-open。Hub access-token jti 黑名单(logout 即时吊销,#888)在 Redis 故障时默认 fail-open。此前无风险登记项。

变更

  • docs/governance/security-risk-register.md:新增 AH-SR-052(Medium 表),登记默认 fail-open 行为、补偿控制(operator 在生产设 AGENTHUB_AUTH_FAIL_CLOSED=true)、关闭条件(flip default 或 verify 部署注入 env)、owner 和 Accepted 日期。

证据

  • real_tested=false:纯治理文档登记。
  • python scripts/verify/verify-doc-ssot.py 全绿。

Co-authored-by: Cursor <cursor@vectorcontrol.tech>
@coderabbitai

coderabbitai Bot commented Aug 17, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@DeliciousBuding, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 40 minutes

Limit details: You’ve used all 1 included review currently available under your plan.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 5ec5b055-eb97-422a-ba24-6345534390d0

📥 Commits

Reviewing files that changed from the base of the PR and between 2966db7 and 25c97e9.

📒 Files selected for processing (1)
  • docs/governance/security-risk-register.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@DeliciousBuding
DeliciousBuding merged commit b0ae928 into master Aug 17, 2026
29 checks passed
@DeliciousBuding
DeliciousBuding deleted the docs/auth-fail-closed-risk-register branch August 17, 2026 13:26
DeliciousBuding added a commit that referenced this pull request Aug 18, 2026
AH-SR-052(auth fail-closed 默认 fail-open)于 #1745(2026-08-17 合并)
登记为 Accepted,但登记表头部"最后审查"仍停留在 2026-08-09。同步到
2026-08-18 以反映最新风险队列。

Co-authored-by: Cursor <cursor@vectorcontrol.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant