Repository navigation
Add reproducible scheduling benchmark and experimental comparison - #3
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a fixed, paired experiment comparing three independently trained Q-Learning models with FIFO, SPT, EDF, Priority, and seeded Random. Run it with
adaptivequeue benchmark --output-dir benchmark-results; cached models are validated against the protocol, and--retrainregenerates them.Models train on mixed workloads for 1,000 episodes at seeds 42, 2042, and 4042 with existing defaults. Evaluation covers stable, bursty, and mixed workloads at seeds 20000–20029, with each job set generated once and reused for all policies. RL evaluation is greedy and leaves Q-values and RNG state unchanged.
The committed reference run includes 720 per-episode metric rows, 24 summary rows with paired cost differences/win rates, 36 action-frequency rows (including contended-only frequencies), both figures, three saved Q-tables, and protocol metadata. Summary statistics average episode metrics, including episode P95 waiting time; training runs remain separate.
Observed mean primary cost J (lower is better):
Priority has the best classical mean cost in each workload. Two RL runs improve on it in stable and bursty workloads, but every RL run loses to Priority on mixed. SPT achieves the lowest deadline-miss rate in every workload.
docs/experiments.mdincludes all five baselines, paired comparisons, action mixes, reproduction details, and the limitations of three training seeds at one load/deadline setting.Validation: inspected six preliminary baseline episodes before the fixed final run; all 81 pytest tests pass, along with Ruff lint/format, strict mypy targeting Python 3.10, and whitespace checks. Fresh/cached reproducibility, identical evaluation job objects, aggregation, frozen evaluation, and figure generation are tested. Matplotlib is an optional benchmark dependency; existing baseline and RL CLI tests remain passing.