fix: AI message dismiss button #1403
Open
+28
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when message that created thread was deleted, retrieveStartMessage() threw an error UNKNOWN_MESSAGE leading to non-functional dismiss button. this adds a handler, specifically for parent message deleted error by using getIterableHistoryInstead.
tj-wazei
requested changes
Feb 1, 2026
application/src/main/java/org/togetherjava/tjbot/features/help/HelpThreadCreatedListener.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/features/help/HelpThreadCreatedListener.java
Outdated
Show resolved
Hide resolved
Zabuzard
reviewed
Feb 2, 2026
application/src/main/java/org/togetherjava/tjbot/features/help/HelpThreadCreatedListener.java
Outdated
Show resolved
Hide resolved
Zabuzard
reviewed
Feb 2, 2026
application/src/main/java/org/togetherjava/tjbot/features/help/HelpThreadCreatedListener.java
Outdated
Show resolved
Hide resolved
* move AI dismiss fallback consumer to a seperate function for clarity * move variable FIRST_MESSAGE_ONLY to function scope as noOfMessage for clarity * improve error log message for clarity
tj-wazei
approved these changes
Feb 2, 2026
|
|
||
| private Consumer<Throwable> handleParentMessageDeleted(Member user, ThreadChannel channel, | ||
| ButtonInteractionEvent event, List<String> args) { | ||
| int noOfMessages = 1; // we only care about first message from channel history |
Contributor
There was a problem hiding this comment.
this is fine though I'd personally would have just not bothered and did limit(1)
Zabuzard
approved these changes
Feb 3, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when message that created thread was deleted,
retrieveStartMessage() threw an error UNKNOWN_MESSAGE leading to non-functional dismiss button.
this adds a handler, specifically for parent message deleted error by using getIterableHistoryInstead.
resolves #1400