dwarf: use unsigned loop index in LEB128 readers - #50
Open
sreekotay wants to merge 1 commit into
Open
Conversation
sreekotay
force-pushed
the
pr/dwarf-leb128-unsigned-i
branch
from
August 11, 2026 05:08
bd04b01 to
5f5d687
Compare
Quiet -Wsign-compare in dwarf_read_uleb128 / dwarf_read_sleb128: the bound is DWARF_MAX_128 (unsigned-friendly) and i is only used as a shift count.
sreekotay
force-pushed
the
pr/dwarf-leb128-unsigned-i
branch
from
August 11, 2026 05:09
5f5d687 to
8986ac9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dwarf_read_uleb128/dwarf_read_sleb128, the loop indexiis compared againstDWARF_MAX_128and used only as a shift count.int itounsigned ito quiet-Wsign-compareunder stricter warning builds.Test plan
-Wsign-compare(or the project default warning set) and confirm the two LEB128 readers no longer warnMade with Cursor