Repository navigation
DDIR: sum integer values by key - #1102
Merged
frankmcsherry merged 1 commit intoNov 20, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a per-key
sumfor collections with integer values.Each update contributes its value times its signed diff. A nonzero total produces one row for the key. A zero total produces none, matching
count.The parser expands
sumintolift, ajoin_functionthat moves the value into the diff, andcount. The arrangement therefore holds unit values, and the lifted timestamp preserves all coordinates at any scope depth. The diff slot enforces the integer input type.sumremains available as a binding name.Tests exercise signed values and diffs, cancellation and reappearance, incomparable root timestamps, nested scopes, and rejection of non-integer inputs.
Ran
cargo test --no-fail-fast -p interactive -p ddir-server(396 passed, 9 ignored), round-tripped the printed balance plan withddir-plan, and checked the balance example with one and three server workers.