feat: add support for moveCountLimit

[cristianonicolai]

Related to https://github.com/TimefoldAI/timefold-platform/issues/5271

[Copilot]

Pull request overview

This PR extends the service termination configuration to support a new moveCountLimit hard cap, wiring it from platform config and per-request API through to solver TerminationConfig, with accompanying tests and user documentation updates.

Changes:

• Add moveCountLimit to SolverTerminationConfig API model and propagate it through TerminationService.
• Disable diminished-returns termination whenever moveCountLimit is set (mirroring existing step-count behavior) and allow combining step + move limits.
• Update tests and the consumer guide to cover and document the new option.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
service/worker/src/test/java/ai/timefold/solver/service/worker/impl/termination/TerminationServiceTest.java	Extends worker termination tests to cover moveCountLimit behavior and its interaction with diminished returns.
service/worker/src/main/java/ai/timefold/solver/service/worker/impl/termination/TerminationService.java	Adds platform-level moveCountLimit support and forwards request/platform resolution into TerminationConfig.
service/worker/src/main/java/ai/timefold/solver/service/worker/impl/termination/TerminationConfigParams.java	Introduces the new platform config key for move count limit.
service/definition/src/test/java/ai/timefold/solver/service/definition/api/termination/SolverTerminationConfigTest.java	Adds API-model tests for new constructor/override behavior involving moveCountLimit.
service/definition/src/main/java/ai/timefold/solver/service/definition/api/termination/SolverTerminationConfig.java	Adds moveCountLimit to the public API record and updates override/conflict rules and schema docs.
docs/src/modules/ROOT/pages/running-timefold-solver/service/consumer-guide.adoc	Documents moveCountLimit, its constraints, and its combination behavior with stepCountLimit.

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

[Copilot]

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.

Suppressed comments (2)

service/test-model/src/build/openapi.json:11

• This PR is scoped to moveCountLimit but the committed OpenAPI snapshot also changes the API version/path to v1 and adds unrelated schema changes (for example MapsConfiguration.useTraffic), so please confirm these are intended or split/regenerate the snapshot to avoid unrelated API diffs.

    "version" : "v1"

service/definition/src/main/java/ai/timefold/solver/service/definition/api/termination/SolverTerminationConfig.java:55

• The schema/docs state unimprovedSpentLimit must not be combined with stepCountLimit or moveCountLimit, but the canonical constructor currently accepts that invalid combination and it will be silently resolved/ignored later, so add the same mutual-exclusion validation used in override().

    public SolverTerminationConfig {
        if (minimumImprovementRatio != null && minimumImprovementRatio <= 0) {
            throw new IllegalArgumentException(
                    "minimumImprovementRatio (" + minimumImprovementRatio + ") must be strictly positive.");
        }
    }

[sonarqubecloud]

Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
97.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[zepfred]

Are these changes correct?

[cristianonicolai]

yes, but not related to this pr, it only adds the new fields. It will be removed once #2571 is merged.

[zepfred]

        var limits = new ArrayList<>(2);

[cristianonicolai]

that would break the String.join(" or ", limits)`

[zepfred]

LGTM! Thank you for implementing the feature so quickly!

[mswiderski]

isn't this being renamed to avoid platform name in the properties? https://github.com/TimefoldAI/timefold-solver/pull/2545/changes#diff-63b1e917bd1fd3d3dd458d719056346ef3d51d23086b99b84b326ee7a0bf163cR5