fix(ci): serialize concurrent gh-pages deploys - #95
TimeToBuildBob wants to merge 5 commits into
Conversation
Review guide (auto-posted)Structured warm-up for reviewers — what changed, what to run, where to look. Key files
Suggested verification
Known risks / watch points
Suggested review focus
Generated by |
|
CI-green and mergeable — waiting only on a maintainer click. Self-merge not eligible here (policy gate): |
🤖 AI code reviewSafe to merge — 1 P1 disposed (fixed in 12ce1de)Updated after inline dispositions on finding threads — this is the current state; the verdict below is frozen at review time and is kept as the historical record of that pass. Finding disposition
Not safe to merge — 1 P1 openConfidence 3/5 1 finding · ❌ 1 P1❌ P1 high —
Previous review passes
Reviewed Maintainer commands
|
Two master pushes nine seconds apart raced JamesIves' force-push (`cannot lock ref` on gh-pages). The later SHA already deployed; this stops the next pair from failing the same way. Git-Session-Id: a7931123-aeaf-5b22-8f8c-14ffd00e1b70
Git-Session-Id: c9063c51-a7c6-5f88-900d-6f733728b631
Git-Session-Id: c9063c51-a7c6-5f88-900d-6f733728b631
570c19b to
e8cfa56
Compare
Git-Session-Id: 67c03aff-1994-5132-ace7-1596a65310ad
Git-Session-Id: 589ba7eb-1021-5e40-bd2d-26bc761e1159
|
@greptileai review |
|
Fixed one additional workflow bug in |
Why
Master CI run 35056225053 failed deploying
8feb760e(docs(blog): publish it-found-the-dead-analytics-it-called-them-p2). The Build step succeeded; Deploy failed with:Cause: two master pushes 9 seconds apart (
8feb760eat 04:36:02Z,7fd414e5at 04:36:11Z) both force-pushedgh-pagesvia JamesIves. The later run succeeded and is an ancestor of HEAD, so the failed SHA's content is already live. Do not rerun 35056225053 — that would rollgh-pagesback to the older SHA.Change
gh-pagesconcurrently.Checks
8feb760eis parent of the later successful master SHA7fd414e5tests/test_check_deploy_is_current.pycovers current-head deploy and stale-run skippytest tests/test_check_deploy_is_current.py -qcheck-yamlpre-commit hooke8cfa560973b65253498f693d1d7a4a1998f2574No site content change.