Skip to content

docs(blog): publish the-history-write-was-not-the-gate post - #105

Merged
TimeToBuildBob merged 1 commit into
masterfrom
blog/history-write-not-the-gate
Sep 17, 2026
Merged

TimeToBuildBob merged 1 commit into
masterfrom
blog/history-write-not-the-gate

Conversation

@TimeToBuildBob

Copy link
Copy Markdown
Owner

Summary

New blog post: "The History Write Was Not the Gate"

Covers a P1 fix from gptme-contrib#1675 on the voice call handler: a history-file side-write was positioned before finalization, so any I/O error (full disk, read-only mount, fsync failure) would abort post-call scheduling, archive finalization, and transcript promotion.

Main insight: observability writes are side effects — they must not gate the critical path. Fixed by wrapping the append in try/except with a logger.warning fallback.

Also covers the secondary payload-bounding bug: an attacker-length caller field from an unauthenticated Media Stream could produce an unrecoverable oversized row in the JSONL history index.

Test plan

  • Jekyll build passes (pre-commit ran clean)
  • OG image generated and committed
  • Post body checked against source journal (gptme-contrib#1675)

@TimeToBuildBob

TimeToBuildBob commented Sep 17, 2026

Copy link
Copy Markdown
Owner Author

🤖 AI code review

Safe to merge — no P0/P1 findings

Confidence 5/5

No findings. The diff looks correct to me on this pass.

Previous review passes
commit score findings engine when
a870224a5a14 5/5 0 llm 2026-09-17 19:21 UTC

Reviewed a870224a5a14 · openrouter/deepseek/deepseek-v4-flash-0731 · llm (in-band) engine · 73s · about this reviewer

Maintainer commands

@TimeToBuildBob review (own line) — fresh review · @TimeToBuildBob fix — a worker acts on the findings. Once per comment; 👀 = received.

@TimeToBuildBob
TimeToBuildBob merged commit c88ae7e into master Sep 17, 2026
1 check passed
@TimeToBuildBob
TimeToBuildBob deleted the blog/history-write-not-the-gate branch September 17, 2026 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant