feat(cloud_server): implement SSL secure websocket from semver2 into semver3 - #723
Open
Boss-1s wants to merge 4 commits into
Open
feat(cloud_server): implement SSL secure websocket from semver2 into semver3#723Boss-1s wants to merge 4 commits into
Boss-1s wants to merge 4 commits into
Conversation
…semver3 Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
- Moved `BaseCloudServer` (Formerly `_SaCloudServer`) to sa.eventhandlers._base Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves nothing
Changes
_SaWebSockectServerto keep things pythonic and organizedTests
First, start up an insecure server to ensure it works:
While the above script is running, run
websocat ws://127.0.0.1:8080to interact with the websocket.Once you have determined that this works, replace the above script with the one below:
Then, generate an OpenSSL certificate:
Finally, run the server script, and interact with the WebSocket with
websocat -k wss://127.0.0.1:8080Notes
might wanna have #722 fixed before merging this, idk