Skip to content

feat: Temporarily negate ProjectAuthenticationWarning when using Project.is_shared() #610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
faretek1 merged 3 commits into from
May 10, 2026
+5 −5
Merged

feat: Temporarily negate ProjectAuthenticationWarning when using Project.is_shared() #610

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
af5297c
feat: temporarily negate warnings in `Project.is_shared` method
Boss-1s May 9, 2026
40c96a4
fix: missing colon
Boss-1s May 9, 2026
9fe2da0
use api endpoint directly
TheCommCraft May 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions scratchattach/site/project.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
import warnings
import zipfile
from io import BytesIO
from typing import Callable, Union
from typing import Callable, Union, cast

from dataclasses import dataclass, field
from typing import Any, Optional
Expand Down Expand Up @@ -185,11 +185,11 @@ def is_shared(self):
Returns:
boolean: Returns whether the project is currently shared
"""
try:
p = get_project(self.id)
return isinstance(p, Project)
except exceptions.ProjectNotFound:
response = requests.get(f"https://api.scratch.mit.edu/projects/{self.id}")
Copy link
Copy Markdown
Collaborator

@faretek1 faretek1 May 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could use self.update_api and self.update_method here although this isn't technically an update method so maybe it should be decoupled. But this is fine

if response.status_code == 404:
return False
response_json = cast(ProjectDict, response.json())
return response_json["is_published"]

def raw_json_or_empty(self) -> dict[str, Any]:
return empty_project_json
Expand Down
Loading