fix: decode_session_id: detect compression #561
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This probably doesn't affect anyone but it is more accurate Closes #540
Collaborator
Author
|
the failing tests no longer are because of the changes in this pr, it's because of the changes on the scratch backend |
Collaborator
Author
|
it may be a reasonable to run daily tests so that we catch these kinds of changes on the scratch backend sooner |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This probably doesn't affect anyone but it is more accurate
Closes #540
Changes
Fixes the django sessionid
zlibtechnicality. will also fix the failing testsTests
no new tests needed, although it looks like some older tests are failing from new changes on scratch's end