Fix: update meson options to avoid deprecation warnings#764
Merged
mvandervoord merged 2 commits intoMar 27, 2026
Conversation
dloidolt
commented
Jan 22, 2025
dloidolt
commented
- Remove quotes from boolean values in meson_options.txt
- see https://mesonbuild.com/Release-notes-for-1-1-0.html#coercing-values-in-the-option-function-is-deprecated
- Remove quotes from boolean values in meson_options.txt - see https://mesonbuild.com/Release-notes-for-1-1-0.html#coercing-values-in-the-option-function-is-deprecated
Contributor
|
@lovetheguitar also approved this (thumbs-up), so I am not sure what are conflicts remaining but @mvandervoord can probably merge it. |
Yes, totally works to get rid of the warning 👍 |
mvandervoord
pushed a commit
that referenced
this pull request
May 22, 2026
Commit 6502a67 (merge of PR #764) accidentally downgraded the `extension_memory` option from `type: 'feature'` to `type: 'boolean'` during conflict resolution. The PR itself just removed quotes around boolean values (the Meson 1.1 deprecation fix), but its branch was based on an older master where extension_memory was still boolean; the merge resolution chose that stale version over master's `feature`. meson.build still calls `build_memory.enabled()` and `.auto()`, which are feature-option methods; on a boolean option they raise: ERROR: Unknown method "enabled" in object <[BooleanHolder] holds [bool]: False> of type BooleanHolder. Restore the `type: 'feature', value: 'auto'` declaration that existed on master before the merge. No change needed in meson.build; its usage of enabled() + auto() is correct for a feature option. Verified: - `meson setup` now succeeds (pre-fix: failed with the error above) - `meson configure -Dextension_memory=enabled` applies cleanly - `ninja -C build` builds libunity.a including the memory extension
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.