Nix flake as an installation option#36
Nix flake as an installation option#36temidaradev wants to merge 3 commits intoThreeDotsLabs:masterfrom
Conversation
roblaszczak
left a comment
roblaszczak
left a comment
There was a problem hiding this comment.
hey @temidaradev, thanks for contribution
I have some comments, please let me know if they makes sense and if they require some work you will have capacity to pick them up
thanks!
|
|
||
| subPackages = [ "tdl" ]; | ||
|
|
||
| vendorHash = "sha256-Q3MwzslcVv9h3QZAfqnAYmkdVtWeJnhXqYvhZmb3hps="; |
There was a problem hiding this comment.
when it will require re-generation?
could it make sense to add script in makefile to regenerate it and if it may change often add CI task that can verify it?
There was a problem hiding this comment.
It will only require regeneration whenever the Go dependencies (go.mod/go.sum) change.
| flake-utils.lib.eachDefaultSystem (system: | ||
| let | ||
| pkgs = nixpkgs.legacyPackages.${system}; | ||
| version = if self ? rev then self.rev else "dev"; |
There was a problem hiding this comment.
just to double check, will it work with our tags/github semver releases?
There was a problem hiding this comment.
Yep, it works perfectly with tags Users can install a specific release by just appending the tag, like nix profile add github:ThreeDotsLabs/cli/v1.0.0.
|
Will handle this evening |
|
Thanks @temidaradev! |
2 participants
Added flake.nix for adding nix package manager as a installation option