refactor(architecture): simplify boundaries by zerob13 · Pull Request #1429 · ThinkInAIXYZ/deepchat

zerob13 · 2026-04-03T12:59:00Z

No description provided.

coderabbitai · 2026-04-03T13:01:39Z

Important

Review skipped

Too many files!

This PR contains 241 files, which is 91 over the limit of 150.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 5bad0d00-6fdb-4bd5-8829-76e40040b32a

📥 Commits

Reviewing files that changed from the base of the PR and between 3f6eb5e and 0f4f851.

📒 Files selected for processing (241)

archives/code/dead-code-batch-2/README.md
archives/code/dead-code-batch-2/src/main/presenter/agentPresenter/events.ts
archives/code/dead-code-batch-2/src/main/presenter/agentPresenter/message/index.ts
archives/code/dead-code-batch-2/src/main/presenter/agentPresenter/message/systemEnvPromptBuilder.ts
archives/code/dead-code-batch-2/src/main/presenter/agentPresenter/permission/index.ts
archives/code/dead-code-batch-2/src/main/presenter/agentPresenter/session/index.ts
archives/code/dead-code-batch-2/src/main/presenter/agentPresenter/streaming/index.ts
archives/code/dead-code-batch-2/src/main/presenter/agentPresenter/tool/index.ts
archives/code/dead-code-batch-2/src/main/presenter/agentPresenter/tools/questionTool.ts
archives/code/dead-code-batch-2/src/main/presenter/agentPresenter/utility/index.ts
archives/code/dead-code-batch-2/src/main/presenter/searchPrompts/index.ts
archives/code/dead-code-batch-2/src/main/presenter/sessionPresenter/persistence/index.ts
archives/code/dead-code-batch-2/src/main/presenter/sessionPresenter/tab/index.ts
archives/code/dead-code-batch-2/src/renderer/src/components/NewThreadMock.vue
archives/code/dead-code-batch-2/src/renderer/src/components/mock/MockChatPage.vue
archives/code/dead-code-batch-2/src/renderer/src/components/mock/MockInputBox.vue
archives/code/dead-code-batch-2/src/renderer/src/components/mock/MockInputToolbar.vue
archives/code/dead-code-batch-2/src/renderer/src/components/mock/MockMessageList.vue
archives/code/dead-code-batch-2/src/renderer/src/components/mock/MockStatusBar.vue
archives/code/dead-code-batch-2/src/renderer/src/components/mock/MockTopBar.vue
archives/code/dead-code-batch-2/src/renderer/src/components/mock/MockWelcomePage.vue
archives/code/dead-code-batch-2/src/renderer/src/composables/useMockViewState.ts
archives/code/dead-code-batch-3/README.md
archives/code/dead-code-batch-3/src/main/presenter/mcpPresenter/inMemoryServers/meetingServer.ts
archives/code/dead-renderer-batch-1/README.md
archives/code/dead-renderer-batch-1/src/renderer/src/components/MessageNavigationSidebar.vue
archives/code/dead-renderer-batch-1/src/renderer/src/components/message/MessageMinimap.vue
archives/code/dead-renderer-batch-1/src/renderer/src/composables/message/useMessageMinimap.ts
archives/code/dead-renderer-batch-1/src/renderer/src/lib/messageRuntimeCache.ts
archives/code/legacy-agentpresenter-retirement/README.md
archives/code/legacy-agentpresenter-retirement/src/main/presenter/agentPresenter/acp/backgroundExecSessionManager.ts
archives/code/legacy-agentpresenter-retirement/src/main/presenter/agentPresenter/acp/index.ts
archives/code/legacy-agentpresenter-retirement/src/main/presenter/agentPresenter/acp/shellEnvHelper.ts
archives/code/legacy-agentpresenter-retirement/src/main/presenter/agentPresenter/agent/index.ts
archives/code/legacy-agentpresenter-retirement/src/main/presenter/agentPresenter/index.ts
archives/code/legacy-agentpresenter-retirement/src/main/presenter/agentPresenter/loop/agentLoopHandler.ts
archives/code/legacy-agentpresenter-retirement/src/main/presenter/agentPresenter/loop/errorClassification.ts
archives/code/legacy-agentpresenter-retirement/src/main/presenter/agentPresenter/loop/index.ts
archives/code/legacy-agentpresenter-retirement/src/main/presenter/agentPresenter/loop/loopOrchestrator.ts
archives/code/legacy-agentpresenter-retirement/src/main/presenter/agentPresenter/loop/loopState.ts
archives/code/legacy-agentpresenter-retirement/src/main/presenter/agentPresenter/loop/toolCallHandler.ts
archives/code/legacy-agentpresenter-retirement/src/main/presenter/agentPresenter/loop/toolCallProcessor.ts
archives/code/legacy-agentpresenter-retirement/src/main/presenter/agentPresenter/message/messageBuilder.ts
archives/code/legacy-agentpresenter-retirement/src/main/presenter/agentPresenter/message/messageCompressor.ts
archives/code/legacy-agentpresenter-retirement/src/main/presenter/agentPresenter/message/messageTruncator.ts
archives/code/legacy-agentpresenter-retirement/src/main/presenter/agentPresenter/message/skillsPromptBuilder.ts
archives/code/legacy-agentpresenter-retirement/src/main/presenter/agentPresenter/permission/permissionHandler.ts
archives/code/legacy-agentpresenter-retirement/src/main/presenter/agentPresenter/persistence/index.ts
archives/code/legacy-agentpresenter-retirement/src/main/presenter/agentPresenter/runtimePorts.ts
archives/code/legacy-agentpresenter-retirement/src/main/presenter/agentPresenter/session/sessionContext.ts
archives/code/legacy-agentpresenter-retirement/src/main/presenter/agentPresenter/session/sessionManager.ts
archives/code/legacy-agentpresenter-retirement/src/main/presenter/agentPresenter/session/sessionResolver.ts
archives/code/legacy-agentpresenter-retirement/src/main/presenter/agentPresenter/session/sessionRuntimePort.ts
archives/code/legacy-agentpresenter-retirement/src/main/presenter/agentPresenter/streaming/contentBufferHandler.ts
archives/code/legacy-agentpresenter-retirement/src/main/presenter/agentPresenter/streaming/llmEventHandler.ts
archives/code/legacy-agentpresenter-retirement/src/main/presenter/agentPresenter/streaming/streamGenerationHandler.ts
archives/code/legacy-agentpresenter-retirement/src/main/presenter/agentPresenter/streaming/streamUpdateScheduler.ts
archives/code/legacy-agentpresenter-retirement/src/main/presenter/agentPresenter/streaming/types.ts
archives/code/legacy-agentpresenter-retirement/src/main/presenter/agentPresenter/tool/toolCallCenter.ts
archives/code/legacy-agentpresenter-retirement/src/main/presenter/agentPresenter/tool/toolRegistry.ts
archives/code/legacy-agentpresenter-retirement/src/main/presenter/agentPresenter/tool/toolRouter.ts
archives/code/legacy-agentpresenter-retirement/src/main/presenter/agentPresenter/types.ts
archives/code/legacy-agentpresenter-retirement/src/main/presenter/agentPresenter/types/handlerContext.ts
archives/code/legacy-agentpresenter-retirement/src/main/presenter/agentPresenter/utility/promptEnhancer.ts
archives/code/legacy-agentpresenter-retirement/src/main/presenter/agentPresenter/utility/utilityHandler.ts
archives/code/legacy-agentpresenter-retirement/src/shared/types/presenters/agent.presenter.d.ts
archives/code/legacy-agentpresenter-retirement/test/main/presenter/agentPresenter/agentPresenter.test.ts
archives/code/legacy-agentpresenter-retirement/test/main/presenter/agentPresenter/loop/agentLoopHandler.test.ts
archives/code/legacy-agentpresenter-retirement/test/main/presenter/agentPresenter/loop/toolCallProcessor.test.ts
archives/code/legacy-agentpresenter-retirement/test/main/presenter/agentPresenter/message/systemEnvPromptBuilder.test.ts
archives/code/legacy-agentpresenter-retirement/test/main/presenter/agentPresenter/messageBuilder.test.ts
archives/code/legacy-agentpresenter-retirement/test/main/presenter/agentPresenter/messageCompressor.test.ts
archives/code/legacy-agentpresenter-retirement/test/main/presenter/agentPresenter/permission/permissionHandler.resume.test.ts
archives/code/legacy-agentpresenter-retirement/test/main/presenter/agentPresenter/promptBuilder.test.ts
archives/code/legacy-agentpresenter-retirement/test/main/presenter/agentPresenter/sessionManager.test.ts
archives/code/legacy-agentpresenter-retirement/test/main/presenter/agentPresenter/skillsPromptBuilder.test.ts
archives/code/legacy-agentpresenter-retirement/test/main/presenter/agentPresenter/streaming/llmEventHandler.test.ts
archives/code/legacy-agentpresenter-retirement/test/main/presenter/agentPresenter/streaming/streamGenerationHandler.test.ts
archives/code/legacy-agentpresenter-retirement/test/main/presenter/sessionPresenter/permissionHandler.test.ts
docs/ARCHITECTURE.md
docs/FLOWS.md
docs/README.md
docs/architecture/agent-system.md
docs/architecture/baselines/archive-reference-report.md
docs/architecture/baselines/dependency-report.md
docs/architecture/baselines/test-failure-groups.md
docs/architecture/baselines/zero-inbound-candidates.md
docs/architecture/new-ui-implementation-plan.md
docs/architecture/session-management.md
docs/architecture/tool-system.md
docs/archives/legacy-agentpresenter-architecture.md
docs/archives/legacy-agentpresenter-flows.md
docs/guides/code-navigation.md
docs/guides/getting-started.md
docs/specs/acp-session-config-options/plan.md
docs/specs/acp-session-config-options/spec.md
docs/specs/acp-session-config-options/tasks.md
docs/specs/agent-cleanup/spec.md
docs/specs/agent-cleanup/tasks.md
docs/specs/agent-db-legacy-import/plan.md
docs/specs/agent-db-legacy-import/spec.md
docs/specs/agent-input-advanced-config/plan.md
docs/specs/agent-input-advanced-config/tasks.md
docs/specs/agentpresenter-mvp-replacement/gap-analysis.md
docs/specs/agentpresenter-mvp-replacement/plan.md
docs/specs/agentpresenter-mvp-replacement/spec.md
docs/specs/agentpresenter-mvp-replacement/tasks.md
docs/specs/app-spotlight-search/plan.md
docs/specs/app-spotlight-search/tasks.md
docs/specs/architecture-simplification/plan.md
docs/specs/architecture-simplification/spec.md
docs/specs/architecture-simplification/tasks.md
docs/specs/floating-agent-widget/plan.md
docs/specs/legacy-agentpresenter-retirement/spec.md
docs/specs/message-toolbar-actions/plan.md
docs/specs/message-toolbar-actions/spec.md
docs/specs/message-toolbar-actions/tasks.md
docs/specs/message-trace-storage/plan.md
docs/specs/message-trace-storage/tasks.md
docs/specs/new-agent/plan.md
docs/specs/new-agent/spec.md
docs/specs/new-agent/tasks.md
docs/specs/new-agent/v2-spec.md
docs/specs/new-agent/v3-spec.md
docs/specs/new-ui-chat-components/spec.md
docs/specs/new-ui-implementation/todo.md
docs/specs/new-ui-pages/spec.md
docs/specs/remote-tool-interactions/plan.md
docs/specs/settings-dashboard/plan.md
docs/specs/settings-dashboard/tasks.md
docs/specs/subagent-orchestrator/plan.md
docs/specs/subagent-orchestrator/spec.md
docs/specs/subagent-orchestrator/tasks.md
docs/specs/telegram-remote-control/plan.md
docs/specs/telegram-remote-control/tasks.md
docs/specs/tool-output-guardrails/plan.md
package.json
scripts/agent-cleanup-guard.mjs
scripts/architecture-guard.mjs
scripts/generate-architecture-baseline.mjs
src/main/lib/agentRuntime/systemEnvPromptBuilder.ts
src/main/presenter/agentRuntimePresenter/accumulator.ts
src/main/presenter/agentRuntimePresenter/compactionService.ts
src/main/presenter/agentRuntimePresenter/contextBuilder.ts
src/main/presenter/agentRuntimePresenter/dispatch.ts
src/main/presenter/agentRuntimePresenter/echo.ts
src/main/presenter/agentRuntimePresenter/index.ts
src/main/presenter/agentRuntimePresenter/internalSessionEvents.ts
src/main/presenter/agentRuntimePresenter/messageStore.ts
src/main/presenter/agentRuntimePresenter/messageTracePayload.ts
src/main/presenter/agentRuntimePresenter/pendingInputCoordinator.ts
src/main/presenter/agentRuntimePresenter/pendingInputStore.ts
src/main/presenter/agentRuntimePresenter/process.ts
src/main/presenter/agentRuntimePresenter/sessionStore.ts
src/main/presenter/agentRuntimePresenter/toolOutputGuard.ts
src/main/presenter/agentRuntimePresenter/types.ts
src/main/presenter/agentSessionPresenter/agentRegistry.ts
src/main/presenter/agentSessionPresenter/index.ts
src/main/presenter/agentSessionPresenter/legacyImportService.ts
src/main/presenter/agentSessionPresenter/messageManager.ts
src/main/presenter/agentSessionPresenter/sessionManager.ts
src/main/presenter/floatingButtonPresenter/index.ts
src/main/presenter/index.ts
src/main/presenter/lifecyclePresenter/hooks/after-start/legacyImportHook.ts
src/main/presenter/lifecyclePresenter/hooks/after-start/rtkHealthCheckHook.ts
src/main/presenter/lifecyclePresenter/hooks/after-start/usageStatsBackfillHook.ts
src/main/presenter/mcpPresenter/inMemoryServers/conversationSearchServer.ts
src/main/presenter/mcpPresenter/toolManager.ts
src/main/presenter/remoteControlPresenter/index.ts
src/main/presenter/remoteControlPresenter/interface.ts
src/main/presenter/remoteControlPresenter/services/remoteConversationRunner.ts
src/main/presenter/runtimePorts.ts
src/main/presenter/sqlitePresenter/index.ts
src/main/presenter/toolPresenter/runtimePorts.ts
src/renderer/settings/components/DashboardSettings.vue
src/renderer/settings/components/RemoteSettings.vue
src/renderer/src/App.vue
src/renderer/src/components/chat-input/McpIndicator.vue
src/renderer/src/components/chat/ChatStatusBar.vue
src/renderer/src/components/chat/composables/useChatInputMentions.ts
src/renderer/src/components/markdown/MarkdownRenderer.vue
src/renderer/src/components/message/MessageBlockContent.vue
src/renderer/src/components/popup/TranslatePopup.vue
src/renderer/src/components/trace/TraceDialog.vue
src/renderer/src/composables/useAppIpcRuntime.ts
src/renderer/src/composables/useModelCapabilities.ts
src/renderer/src/composables/usePresenter.ts
src/renderer/src/composables/useSearchConfig.ts
src/renderer/src/lib/ipcSubscription.ts
src/renderer/src/lib/storeInitializer.ts
src/renderer/src/lib/windowContext.ts
src/renderer/src/pages/ChatPage.vue
src/renderer/src/pages/NewThreadPage.vue
src/renderer/src/stores/ui/agent.ts
src/renderer/src/stores/ui/message.ts
src/renderer/src/stores/ui/messageIpc.ts
src/renderer/src/stores/ui/pageRouter.ts
src/renderer/src/stores/ui/pendingInput.ts
src/renderer/src/stores/ui/session.ts
src/renderer/src/stores/ui/sessionIpc.ts
src/renderer/src/stores/ui/spotlight.ts
src/renderer/src/stores/ui/stream.ts
src/shared/types/agent-interface.d.ts
src/shared/types/presenters/agent-session.presenter.d.ts
src/shared/types/presenters/index.d.ts
src/shared/types/presenters/legacy.presenters.d.ts
test/main/presenter/agentRuntimePresenter/accumulator.test.ts
test/main/presenter/agentRuntimePresenter/agentRuntimePresenter.test.ts
test/main/presenter/agentRuntimePresenter/compactionService.test.ts
test/main/presenter/agentRuntimePresenter/contextBuilder.test.ts
test/main/presenter/agentRuntimePresenter/dispatch.test.ts
test/main/presenter/agentRuntimePresenter/echo.test.ts
test/main/presenter/agentRuntimePresenter/internalSessionEvents.test.ts
test/main/presenter/agentRuntimePresenter/messageStore.test.ts
test/main/presenter/agentRuntimePresenter/messageTracePayload.test.ts
test/main/presenter/agentRuntimePresenter/pendingInputStore.test.ts
test/main/presenter/agentRuntimePresenter/process.test.ts
test/main/presenter/agentSessionPresenter/agentRegistry.test.ts
test/main/presenter/agentSessionPresenter/agentSessionPresenter.test.ts
test/main/presenter/agentSessionPresenter/integration.test.ts
test/main/presenter/agentSessionPresenter/legacyImportService.test.ts
test/main/presenter/agentSessionPresenter/messageManager.test.ts
test/main/presenter/agentSessionPresenter/sessionManager.test.ts
test/main/presenter/agentSessionPresenter/usageDashboard.test.ts
test/main/presenter/floatingButtonPresenter/index.test.ts
test/main/presenter/mcpPresenter/toolManager.test.ts
test/main/presenter/remoteControlPresenter/remoteControlPresenter.test.ts
test/main/presenter/remoteControlPresenter/remoteConversationRunner.test.ts
test/main/presenter/toolPresenter/agentTools/subagentOrchestratorTool.test.ts
test/renderer/components/ChatPage.test.ts
test/renderer/components/ChatStatusBar.test.ts
test/renderer/components/McpIndicator.test.ts
test/renderer/components/NewThreadPage.test.ts
test/renderer/components/RemoteSettings.test.ts
test/renderer/composables/usePresenter.test.ts
test/renderer/pages/NewThreadPage.test.ts
test/renderer/stores/messageStore.test.ts
test/renderer/stores/pageRouter.test.ts
test/renderer/stores/pendingInputStore.test.ts
test/renderer/stores/sessionStore.test.ts
test/renderer/stores/spotlight.test.ts

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch codex/arch-simple

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

refactor(architecture): simplify boundaries

2fa0f41

refactor(presenter): rename agent presenters

374129d

zerob13 marked this pull request as ready for review April 3, 2026 13:15

fix(agent-runtime): preserve queued inputs

0f4f851

zerob13 merged commit 462da74 into dev Apr 3, 2026
3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(architecture): simplify boundaries#1429

refactor(architecture): simplify boundaries#1429
zerob13 merged 3 commits intodevfrom
codex/arch-simple

zerob13 commented Apr 3, 2026

Uh oh!

coderabbitai bot commented Apr 3, 2026 •

edited

Loading

Review skipped

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

zerob13 commented Apr 3, 2026

Uh oh!

coderabbitai bot commented Apr 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

coderabbitai bot commented Apr 3, 2026 •

edited

Loading