Skip to content

chore: update markdown renderer with pretext#1420

Merged
zerob13 merged 2 commits intodevfrom
chore/update-markdown-renderer
Apr 1, 2026
Merged

chore: update markdown renderer with pretext#1420
zerob13 merged 2 commits intodevfrom
chore/update-markdown-renderer

Conversation

@zerob13
Copy link
Copy Markdown
Collaborator

@zerob13 zerob13 commented Apr 1, 2026

Summary by CodeRabbit

  • Chores

    • Updated Vue-related development dependencies to newer versions.
  • Refactor

    • Improved message scrolling logic to more safely use virtual scroller capabilities with graceful fallbacks, reducing risk of scroll errors and improving scroll reliability.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 1, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c3eb0e68-bf73-4eab-bfe6-8aef2bd89d33

📥 Commits

Reviewing files that changed from the base of the PR and between d0ed34b and b4801bc.

📒 Files selected for processing (1)
  • src/renderer/src/composables/message/useMessageScroll.ts

📝 Walkthrough

Walkthrough

Bumped two Vue-related devDependencies in package.json and changed useMessageScroll to use a DynamicScrollerHandle ref (optional scrollToBottom / scrollToItem functions) with guarded calls and fallbacks to existing base scroll methods.

Changes

Cohort / File(s) Summary
Dependency Version Updates
package.json
Updated devDependencies: markstream-vue 0.0.8-beta.1 → 0.0.10-beta.6; stream-monaco ^0.0.20 → ^0.0.21.
Message scroll composable
src/renderer/src/composables/message/useMessageScroll.ts
Replaced dynamicScrollerRef type with Ref<DynamicScrollerHandle | null>, added exported DynamicScrollerHandle type, and changed scroll calls to use optional handle methods (scrollToBottom, scrollToItem) with guarded fallbacks to base scroll functions.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested reviewers

  • yyhhyyyyyy

Poem

🐰 Hopping code-lines, soft and light,

I nudge the scroller into sight.
Versions updated, handles in tow,
I bound, I patch — and watch messages flow.

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title 'chore: update markdown renderer with pretext' does not accurately describe the actual changes, which involve updating Vue-related devDependencies and refactoring a useMessageScroll composable's scroll handler types. Revise the title to reflect the main changes, such as 'chore: update devDependencies and refactor DynamicScroller ref type' or similar.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/update-markdown-renderer

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@zerob13 zerob13 merged commit d8e8fea into dev Apr 1, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant