Skip to content

bugfix(radar): Preserve hero icon during hidden exit frames #1823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

bugfix(radar): Preserve hero icon during hidden exit frames #1823

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions Generals/Code/GameEngineDevice/Source/W3DDevice/Common/System/W3DRadar.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -654,13 +654,16 @@ void W3DRadar::renderObjectList( const RadarObject *listHead, TextureClass *text

for( const RadarObject *rObj = listHead; rObj; rObj = rObj->friend_getNext() )
{
// get object
const Object *obj = rObj->friend_getObject();

// TheSuperHackers @bugfix arcticdolphin 07/11/2025 Keep hero icon during hidden exit frames
if (calcHero && rObj->isTemporarilyHidden() && obj->isHero())
m_cachedHeroObjectList.push_back(obj);
Copy link

@xezon xezon Nov 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My first impression is that this is a hack fix.


if (rObj->isTemporarilyHidden())
continue;

// get object
const Object *obj = rObj->friend_getObject();

// check for shrouded status
if (obj->getShroudedStatus(playerIndex) > OBJECTSHROUD_PARTIAL_CLEAR)
continue; //object is fogged or shrouded, don't render it.
Expand Down
9 changes: 6 additions & 3 deletions GeneralsMD/Code/GameEngineDevice/Source/W3DDevice/Common/System/W3DRadar.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -652,13 +652,16 @@ void W3DRadar::renderObjectList( const RadarObject *listHead, TextureClass *text

for( const RadarObject *rObj = listHead; rObj; rObj = rObj->friend_getNext() )
{
// get object
const Object *obj = rObj->friend_getObject();

// TheSuperHackers @bugfix arcticdolphin 07/11/2025 Keep hero icon during hidden exit frames
if (calcHero && rObj->isTemporarilyHidden() && obj->isHero())
m_cachedHeroObjectList.push_back(obj);

if (rObj->isTemporarilyHidden())
continue;

// get object
const Object *obj = rObj->friend_getObject();

// check for shrouded status
if (obj->getShroudedStatus(playerIndex) > OBJECTSHROUD_PARTIAL_CLEAR)
continue; //object is fogged or shrouded, don't render it.
Expand Down
Loading