-
Notifications
You must be signed in to change notification settings - Fork 118
tweak: Update LanGameOptionsMenu chat type for consistency #1821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: tintinhamans <5984296+tintinhamans@users.noreply.github.com>
5fe9d3c to
57e7240
Compare
| if (!txtInput.isEmpty()) | ||
| TheLAN->RequestChat(txtInput, LANAPIInterface::LANCHAT_EMOTE); | ||
| // TheSuperHackers @tweak arcticdolphin 07/11/2025 changed from LANCHAT_EMOTE for consistency | ||
| TheLAN->RequestChat(txtInput, LANAPIInterface::LANCHAT_NORMAL); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The button is named "buttonEmoteID". Maybe EMOTE type is intentional? What is the difference?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LANCHAT_EMOTE (first line in screenshot) is used when you press the button that looks like an Enter symbol, LANCHAT_NORMAL (second line in screenshot) is used when you press Enter on your keyboard.
Emote feels like a feature that was never completed, I essentially did the same as what was done for this in the LanLobbyMenu:
Lines 823 to 825 in db3416b
| if (!txtInput.isEmpty()) { | |
| // TheLAN->RequestChat(txtInput, LANAPIInterface::LANCHAT_EMOTE); | |
| TheLAN->RequestChat(txtInput, LANAPIInterface::LANCHAT_NORMAL); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How will the EMOTE be used without the button?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should introduce a /me command that would trigger the Emote formatting.
Emote is also used in the score screen chat and may need evaluation there too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is how it is done in GameSpy code:
Bool handleGameSetupSlashCommands(UnicodeString uText)
{
...
else if (token == "me" && uText.getLength()>4)
{
TheGameSpyInfo->sendChat(UnicodeString(uText.str()+4), TRUE, NULL); // <---- second argument "isAction" makes emote chat
return TRUE; // was a slash command
}
...Ok.
So the action items here are:
- Change all lobby emote lobby buttons to send normal chat (Game Room, Score Screen)
- Rename the "emote" buttons to "chat" buttons
- Implement /me command for Network chat (ideally /me command still works when clicking the button too)
Send same type of chat message when pressing Enter as when pressing the button in the GUI.
Closes #1443