Open
Conversation
Collaborator
Author
|
Going to have a little break from the PR and recheck it later in the week. This was a decent change to the entire code base, so deserves a close review with fresh eyes. |
thomaslaurenson
commented
Apr 7, 2026
Collaborator
Author
thomaslaurenson
left a comment
thomaslaurenson
left a comment
There was a problem hiding this comment.
Couple comments from review
| runs-on: ubuntu-24.04 | ||
| steps: | ||
| - name: Check out repository code | ||
| uses: actions/checkout@v4 |
Collaborator
Author
There was a problem hiding this comment.
Should be v6
| run: sudo apt-get install -y clang-format-18 clang-tidy-18 | ||
|
|
||
| - name: Check formatting | ||
| run: find src \( -name "*.cpp" -o -name "*.h" \) | xargs clang-format-18 --dry-run --Werror |
Collaborator
Author
There was a problem hiding this comment.
Should use makefile for simplicity
| return filePath; | ||
| #endif | ||
| #ifndef _WIN32 | ||
| std::replace(filePath.begin(), filePath.end(), '\\', '/'); |
Collaborator
Author
There was a problem hiding this comment.
Is this a blank line?
| "(signature)", | ||
| "(attributes)" | ||
| }; | ||
| static const std::vector<std::string> kSpecialMpqFiles = {"(listfile)", "(signature)", |
Collaborator
Author
There was a problem hiding this comment.
No format here
| rm -rf build | ||
|
|
||
| ## Generate compile_commands.json for clang-tidy | ||
| build_lint: CMakeLists.txt src/CMakeLists.txt |
Collaborator
Author
There was a problem hiding this comment.
Relook at this solution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.