Repository navigation
Improve escaping in HasCastable.php - #44
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2b346eefc2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } | ||
|
|
||
| return "'" . addslashes($value) . "'"; | ||
| return "'" . str_replace(['\\', "'"], ['\\\\', "\\'"], stripslashes($value)) . "'"; |
There was a problem hiding this comment.
When an input string contains literal backslashes, stripslashes($value) removes them before the replacement can escape them. For example, C:\temp\file.txt becomes 'C:tempfile.txt', and App\Models\User becomes 'AppModelsUser'. The PHP formatter passes original array values directly to castValue(), so these are not previously escaped strings that need decoding. This silently corrupts paths, class names, and other backslash-containing values in the generated PHP. Remove the stripslashes() call and escape the original value directly.
Useful? React with 👍 / 👎.
No description provided.