Skip to content

refactor(genetic_algorithm): optimize evaluate function using zip - #15080

Closed
loulanyue wants to merge 1 commit into
TheAlgorithms:masterfrom
loulanyue:fix/genetic-algorithm-type-annotation
Closed

refactor(genetic_algorithm): optimize evaluate function using zip#15080
loulanyue wants to merge 1 commit into
TheAlgorithms:masterfrom
loulanyue:fix/genetic-algorithm-type-annotation

Conversation

@loulanyue

Copy link
Copy Markdown

Summary

In genetic_algorithm/basic_string.py:

  • evaluate previously constructed a list with [g for position, g in enumerate(item) if g == main_target[position]] and took len(...).
  • If item and main_target have mismatched lengths, indexing main_target[position] can raise IndexError.
  • This PR replaces list comprehension with sum(1 for g, t in zip(item, main_target) if g == t) which is safer, more Pythonic, and avoids intermediate list allocation.

@algorithms-keeper

Copy link
Copy Markdown

Closing this pull request as invalid

@loulanyue, this pull request is being closed as none of the checkboxes have been marked. It is important that you go through the checklist and mark the ones relevant to this pull request. Please read the Contributing guidelines.

If you're facing any problem on how to mark a checkbox, please read the following instructions:

  • Read a point one at a time and think if it is relevant to the pull request or not.
  • If it is, then mark it by putting a x between the square bracket like so: [x]

NOTE: Only [x] is supported so if you have put any other letter or symbol between the brackets, that will be marked as invalid. If that is the case then please open a new pull request with the appropriate changes.

@algorithms-keeper algorithms-keeper Bot added the awaiting reviews This PR is ready to be reviewed label Aug 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting reviews This PR is ready to be reviewed invalid

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant