Skip to content

fix(simplex): raise ValueError instead of returning empty dict when max iterations reached#14590

Closed
unn-Known1 wants to merge 1 commit into
TheAlgorithms:masterfrom
unn-Known1:fix/issue-14584-simplex-convergence-error
Closed

fix(simplex): raise ValueError instead of returning empty dict when max iterations reached#14590
unn-Known1 wants to merge 1 commit into
TheAlgorithms:masterfrom
unn-Known1:fix/issue-14584-simplex-convergence-error

Conversation

@unn-Known1
Copy link
Copy Markdown

Fixes #14584

Problem

The run_simplex() method in linear_programming/simplex.py silently returned an empty dict {} when the maximum iteration limit (Tableau.maxiter) was reached, with no indication of why it failed. This made it impossible for callers to distinguish between:

  • A valid converging solution (returning {"P": 0.0})
  • A cycling or unbounded problem that failed to converge

Solution

Modified run_simplex() to raise a descriptive ValueError when the maximum iterations are exhausted:

raise ValueError(
    "Simplex did not converge within "
    + str(max_iterations)
    + " iterations. The problem may be cycling or unbounded."
)

Testing

  • All existing doctests pass
  • The change is minimal and targeted (7 lines added, 1 line removed)

This contribution was developed with AI assistance.

…ax iterations reached

Fixes TheAlgorithms#14584

The run_simplex() method now raises a descriptive ValueError when
the maximum iteration limit (Tableau.maxiter) is reached, instead of
silently returning an empty dict. This allows callers to distinguish
between a converging solution and a cycling/unbounded problem.
@algorithms-keeper
Copy link
Copy Markdown

Closing this pull request as invalid

@unn-Known1, this pull request is being closed as none of the checkboxes have been marked. It is important that you go through the checklist and mark the ones relevant to this pull request. Please read the Contributing guidelines.

If you're facing any problem on how to mark a checkbox, please read the following instructions:

  • Read a point one at a time and think if it is relevant to the pull request or not.
  • If it is, then mark it by putting a x between the square bracket like so: [x]

NOTE: Only [x] is supported so if you have put any other letter or symbol between the brackets, that will be marked as invalid. If that is the case then please open a new pull request with the appropriate changes.

@algorithms-keeper algorithms-keeper Bot added the awaiting reviews This PR is ready to be reviewed label Apr 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting reviews This PR is ready to be reviewed invalid

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: run_simplex() returns empty dict {} on max iteration instead of raising an informative error

1 participant