fix(simplex): raise ValueError instead of returning empty dict when max iterations reached#14590
Closed
unn-Known1 wants to merge 1 commit into
Closed
Conversation
…ax iterations reached Fixes TheAlgorithms#14584 The run_simplex() method now raises a descriptive ValueError when the maximum iteration limit (Tableau.maxiter) is reached, instead of silently returning an empty dict. This allows callers to distinguish between a converging solution and a cycling/unbounded problem.
Closing this pull request as invalid@unn-Known1, this pull request is being closed as none of the checkboxes have been marked. It is important that you go through the checklist and mark the ones relevant to this pull request. Please read the Contributing guidelines. If you're facing any problem on how to mark a checkbox, please read the following instructions:
NOTE: Only |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14584
Problem
The
run_simplex()method inlinear_programming/simplex.pysilently returned an empty dict{}when the maximum iteration limit (Tableau.maxiter) was reached, with no indication of why it failed. This made it impossible for callers to distinguish between:{"P": 0.0})Solution
Modified
run_simplex()to raise a descriptiveValueErrorwhen the maximum iterations are exhausted:Testing
This contribution was developed with AI assistance.