Fix ml files and add algorithms#14342
Open
M-H-Jishan wants to merge 5 commits intoTheAlgorithms:masterfrom
Open
Fix ml files and add algorithms#14342M-H-Jishan wants to merge 5 commits intoTheAlgorithms:masterfrom
M-H-Jishan wants to merge 5 commits intoTheAlgorithms:masterfrom
Conversation
- Fix 4 broken machine learning files using deprecated sklearn functions - Replace plot_confusion_matrix with ConfusionMatrixDisplay.from_estimator - Replace load_boston with fetch_california_housing dataset - Add proper type hints and comprehensive doctests - Fix FIXME issues in bipartite graph checker - Add input validation for invalid graph structures - Raise ValueError for disconnected nodes - Update type hints to support generic hashable types - Fix filename typo: check_bipatrite.py -> check_bipartite.py - Add new algorithms with educational value - Trie-based autocomplete system with frequency ranking - B-Tree implementation for database-like operations - Rabin-Karp string search with multiple pattern support All new code includes comprehensive doctests and follows project guidelines.
- Fix B-Tree split method to store median key before modifying keys list - Fix B-Tree traverse method to handle child nodes correctly - Fix Trie delete method to properly return False for non-existent words - Update bipartite graph checker to remove overly strict validation - All doctests now pass successfully
for more information, see https://pre-commit.ci
- Fix ambiguous minus sign in B-Tree docstring - Import Hashable from collections.abc instead of typing - Remove unused numpy import from gaussian_naive_bayes.py - Prefix unused fig variables with underscore in ML files - Rename unused loop variable i to _i in rabin_karp_search.py - Combine nested if statements in rabin_karp_search.py All ruff checks now pass for contributed files.
algorithms-keeper
bot
added
enhancement
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| self.children: list[BTreeNode] = [] | ||
| self.is_leaf = is_leaf | ||
|
|
||
| def split(self, parent: BTreeNode, index: int) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/b_tree.py, please provide doctest for the function split
| words_with_freq: list[tuple[str, int]] = [] | ||
| self._collect_words_with_frequency(node, prefix.lower(), words_with_freq) | ||
|
|
||
| words_with_freq.sort(key=lambda x: (-x[1], x[0])) |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: x
algorithms-keeper
bot
added
awaiting reviews
Change 'hel' to 'hell' and 'help' in doctests and examples to avoid codespell flagging it as a typo.
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| self.children: list[BTreeNode] = [] | ||
| self.is_leaf = is_leaf | ||
|
|
||
| def split(self, parent: BTreeNode, index: int) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/b_tree.py, please provide doctest for the function split
| words_with_freq: list[tuple[str, int]] = [] | ||
| self._collect_words_with_frequency(node, prefix.lower(), words_with_freq) | ||
|
|
||
| words_with_freq.sort(key=lambda x: (-x[1], x[0])) |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
Checklist: