Skip to content

Fix ml files and add algorithms#14340

Closed
M-H-Jishan wants to merge 3 commits intoTheAlgorithms:masterfrom
M-H-Jishan:fix-ml-files-and-add-algorithms
Closed

Fix ml files and add algorithms#14340
M-H-Jishan wants to merge 3 commits intoTheAlgorithms:masterfrom
M-H-Jishan:fix-ml-files-and-add-algorithms

Conversation

@M-H-Jishan
Copy link

@M-H-Jishan M-H-Jishan commented Mar 6, 2026

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

M-H-Jishan and others added 3 commits March 6, 2026 23:59
Fix broken ML files, resolve FIXME issues, and add new algorithms
bdf9f9e 
- Fix 4 broken machine learning files using deprecated sklearn functions
  - Replace plot_confusion_matrix with ConfusionMatrixDisplay.from_estimator
  - Replace load_boston with fetch_california_housing dataset
  - Add proper type hints and comprehensive doctests

- Fix FIXME issues in bipartite graph checker
  - Add input validation for invalid graph structures
  - Raise ValueError for disconnected nodes
  - Update type hints to support generic hashable types
  - Fix filename typo: check_bipatrite.py -> check_bipartite.py

- Add new algorithms with educational value
  - Trie-based autocomplete system with frequency ranking
  - B-Tree implementation for database-like operations
  - Rabin-Karp string search with multiple pattern support

All new code includes comprehensive doctests and follows project guidelines.
Fix doctests and bugs in new algorithms
e872888 
- Fix B-Tree split method to store median key before modifying keys list
- Fix B-Tree traverse method to handle child nodes correctly
- Fix Trie delete method to properly return False for non-existent words
- Update bipartite graph checker to remove overly strict validation
- All doctests now pass successfully
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
ed60a0b 
for more information, see https://pre-commit.ci
@algorithms-keeper
Copy link

algorithms-keeper bot commented Mar 6, 2026

Closing this pull request as invalid

@M-H-Jishan, this pull request is being closed as none of the checkboxes have been marked. It is important that you go through the checklist and mark the ones relevant to this pull request. Please read the Contributing guidelines.

If you're facing any problem on how to mark a checkbox, please read the following instructions:

  • Read a point one at a time and think if it is relevant to the pull request or not.
  • If it is, then mark it by putting a x between the square bracket like so: [x]

NOTE: Only [x] is supported so if you have put any other letter or symbol between the brackets, that will be marked as invalid. If that is the case then please open a new pull request with the appropriate changes.

@algorithms-keeper algorithms-keeper bot added awaiting reviews This PR is ready to be reviewed invalid labels Mar 6, 2026
@algorithms-keeper algorithms-keeper bot closed this Mar 6, 2026
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Mar 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

invalid

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@M-H-Jishan