Skip to content

Conversation

@rachit-27
Copy link

Summary

Fixes incorrect output of the binary_search() function when duplicate elements exist.

Details

  • Updated binary_search() in searches/binary_search.py to correctly return a valid index even when duplicates are present.
  • Added tests in tests/searches/test_binary_search_duplicates.py to validate behavior for duplicates, unique elements, and not-found cases.
  • Verified style compliance using Ruff and pre-commit.

Issue Reference

Fixes #13886

@algorithms-keeper
Copy link

Closing this pull request as invalid

@rachit-27, this pull request is being closed as none of the checkboxes have been marked. It is important that you go through the checklist and mark the ones relevant to this pull request. Please read the Contributing guidelines.

If you're facing any problem on how to mark a checkbox, please read the following instructions:

  • Read a point one at a time and think if it is relevant to the pull request or not.
  • If it is, then mark it by putting a x between the square bracket like so: [x]

NOTE: Only [x] is supported so if you have put any other letter or symbol between the brackets, that will be marked as invalid. If that is the case then please open a new pull request with the appropriate changes.

@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting reviews This PR is ready to be reviewed invalid

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Binary Search gives wrong output for duplicate elements

1 participant