Draft
Conversation
Adds Bubble sort, Merge sort, Quick sort, Selection sort and Shell sort.
dlesnoff
commented
Jun 2, 2023
Tried to fix DIRECTORY.md but I do not remember which algorithms are really there ...
Contributor
|
Took a glance over. Looks great, I like the code/comment ratio (I'd spray TODO marks around those I think the testing scaffolding should live somewhere separately. Do you think it would be beneficial to start collecting the testing utils we can recommend to new contributors? Also, in general, I don't like unseeded random in tests. No harm here, but they should be reproducible. Re |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add multiple sorting algorithms: insertion sort, selection sort, bubble sort, merge sort
with a file for some common tests.
I hesitate to add additional tests to illustrate the stability property of some sorts or to add the possibility to change the comparison function.
I want to keep thing simple to be as much pedagogical as possible.