Skip to content

odb: add support for ground-only inter-chip parasitics#10976

Open
AcKoucher wants to merge 5 commits into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:odb-3d-parasitics
Open

odb: add support for ground-only inter-chip parasitics#10976
AcKoucher wants to merge 5 commits into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:odb-3d-parasitics

Conversation

@AcKoucher

@AcKoucher AcKoucher commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Summary

These changes introduce dbChipRSeg and dbChipCapNode. With this, we'll be about to extract parasitics of the inter-chip boundaries (bumps).

Out first version of 3D RCX won't take bump context into account, so we don't need dbChipCCSeg for now.

Differently from dbRSeg, dbCapNode and dbCCSeg which are lists that resolve by corner index, the new objects being added here are a single value, because we'll only support single corner in our initial 3D parasitics extraction.

Type of Change

  • New feature

Impact

None.

Verification

  • I have verified that the local build succeeds (./etc/Build.sh).
  • I have run the relevant tests and they pass.
  • My code follows the repository's formatting guidelines.
  • I have included tests to prevent regressions.
  • I have signed my commits (DCO).

Signed-off-by: Arthur Koucher <arthurkoucher@precisioninno.com>
Signed-off-by: Arthur Koucher <arthurkoucher@precisioninno.com>
Signed-off-by: Arthur Koucher <arthurkoucher@precisioninno.com>
@AcKoucher AcKoucher self-assigned this Jul 23, 2026
@AcKoucher
AcKoucher marked this pull request as ready for review July 23, 2026 04:00
@AcKoucher
AcKoucher requested a review from a team as a code owner July 23, 2026 04:00
@AcKoucher
AcKoucher requested a review from maliberty July 23, 2026 04:00

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces inter-chip parasitics modeling to the ODB database by adding the dbChipCapNode and dbChipRSeg classes, along with their iterators, schema definitions, serialization support, and unit tests. The review feedback focuses on improving robustness and preventing potential crashes. Specifically, it is recommended to add a direct chip_net_ reference to dbChipRSeg to avoid dangling pointer dereferences during destruction, add null checks for chip_net_ during creation of both cap nodes and r-segs, ensure early returns after logging errors in dbChipRSeg::create, and add a null check for the bump instance in dbChipCapNode::getBTerm.

Comment thread src/odb/src/codeGenerator/schema/chip/dbChipRSeg.json
Comment thread src/odb/src/db/dbChipRSeg.cpp
Comment thread src/odb/src/db/dbChipRSeg.cpp
Comment thread src/odb/src/db/dbChipCapNode.cpp
Comment thread src/odb/src/db/dbChipCapNode.cpp
Signed-off-by: Arthur Koucher <arthurkoucher@precisioninno.com>
@eder-matheus

Copy link
Copy Markdown
Member

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c47040398f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/odb/src/db/dbChipNet.h
Signed-off-by: Arthur Koucher <arthurkoucher@precisioninno.com>
@AcKoucher
AcKoucher requested a review from osamahammad21 July 23, 2026 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants