tap: check if selected master cells are placeable#10971
Conversation
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
There was a problem hiding this comment.
Code Review
This pull request introduces validation checks to ensure that the master cells provided for tapcells and endcaps are core auto-placeable. If a master cell is not placeable in core rows, an error is logged to prevent issues during detailed placement. Additionally, a new integration test invalid_master_class has been added to verify this behavior. There are no review comments, and I have no feedback to provide.
|
@codex review |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@gudeh @jeffng-or FYI |
Summary
TAP could use cells that are not placeable as tapcells or endcaps. This PR adds a check to prevent it, throwing an error message when it happens.
Type of Change
Impact
Prevent wrong cells to be used as tap/endcaps.
Verification
./etc/Build.sh).Related Issues
Fixes https://github.com/The-OpenROAD-Project-private/OpenROAD-flow-scripts/issues/1783.