Skip to content

Organize and better document .bazelignore#10959

Merged
maliberty merged 1 commit into
The-OpenROAD-Project:masterfrom
hzeller:feature-20260720-org-bazelign
Jul 24, 2026
Merged

Organize and better document .bazelignore#10959
maliberty merged 1 commit into
The-OpenROAD-Project:masterfrom
hzeller:feature-20260720-org-bazelign

Conversation

@hzeller

@hzeller hzeller commented Jul 20, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@hzeller
hzeller requested a review from a team as a code owner July 20, 2026 18:47
@hzeller
hzeller requested a review from maliberty July 20, 2026 18:47

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the .bazelignore file to reorganize ignored directories, grouping CMake build outputs, downstream consumer tests, and third-party dependencies. Feedback highlights a discrepancy where mockturtle is documented as a Bazel-managed dependency but is currently missing from MODULE.bazel.

Comment thread .bazelignore Outdated
Signed-off-by: Henner Zeller <h.zeller@acm.org>
@hzeller
hzeller force-pushed the feature-20260720-org-bazelign branch from 04be99b to 50058b4 Compare July 21, 2026 05:01
Comment thread .bazelignore

# Various things from third-party/ that might be used by CMake, but
# we have in MODULE.bazel.
# Goal: no sub-modules, only bazel-managed dependencies.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this will happen for OpenSTA but it is good goal otherwise.

@maliberty
maliberty merged commit 6f498fc into The-OpenROAD-Project:master Jul 24, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants