gui: load heatmap before onShow#10956
Open
LucasYuki wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the rendering logic in heatMap.cpp by extracting the call to getVisibleMap() into a local variable before the loop. However, this changes the execution order, calling getVisibleMap() before datasource_.onShow() on the first paint, which can lead to rendering with uninitialized or stale state. It is recommended to preserve the lifecycle order by explicitly calling datasource_.ensureMap() within the initialization block instead.
Signed-off-by: LucasYuki <lucasyuki@yahoo.com.br>
openroad-ci
force-pushed
the
gui-heatmap-warn
branch
from
July 20, 2026 16:00
e41d8e0 to
eeff097
Compare
LucasYuki
marked this pull request as ready for review
July 20, 2026 18:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #4181
The warning GUI-0066 was caused by calling onShow (which checks if the heatmap is loaded) before loading the heatmap.
Type of Change
Impact
[How does this change the tool's behavior?]
Now the warning isn't raised.
Verification
./etc/Build.sh).Related Issues
[Link issues here]
#4181