Skip to content

gui: load heatmap before onShow#10956

Open
LucasYuki wants to merge 1 commit into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:gui-heatmap-warn
Open

gui: load heatmap before onShow#10956
LucasYuki wants to merge 1 commit into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:gui-heatmap-warn

Conversation

@LucasYuki

Copy link
Copy Markdown
Contributor

Summary

Closes #4181

The warning GUI-0066 was caused by calling onShow (which checks if the heatmap is loaded) before loading the heatmap.

Type of Change

  • Bug fix

Impact

[How does this change the tool's behavior?]
Now the warning isn't raised.

Verification

  • [ X ] I have verified that the local build succeeds (./etc/Build.sh).
  • [ X ] I have run the relevant tests and they pass.
  • [ X ] My code follows the repository's formatting guidelines.
  • I have included tests to prevent regressions.
  • [ X ] I have signed my commits (DCO).

Related Issues

[Link issues here]
#4181

@LucasYuki LucasYuki self-assigned this Jul 20, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the rendering logic in heatMap.cpp by extracting the call to getVisibleMap() into a local variable before the loop. However, this changes the execution order, calling getVisibleMap() before datasource_.onShow() on the first paint, which can lead to rendering with uninitialized or stale state. It is recommended to preserve the lifecycle order by explicitly calling datasource_.ensureMap() within the initialization block instead.

Comment thread src/gui/src/heatMap.cpp Outdated
Signed-off-by: LucasYuki <lucasyuki@yahoo.com.br>
@LucasYuki
LucasYuki marked this pull request as ready for review July 20, 2026 18:11
@LucasYuki
LucasYuki requested a review from a team as a code owner July 20, 2026 18:11
@LucasYuki
LucasYuki requested a review from maliberty July 20, 2026 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

IR Drop heatmap complains about not being populated with data and then shows a heat map

1 participant