Updates to fix sky130hd LVS issues - #4516
Open
jeffng-or wants to merge 1 commit into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the LVS flow by passing the top cell name to KLayout, adjusting CDL resistor values and subcircuit syntax, and significantly expanding the LVS script with robust multi-finger transistor folding, 0-ohm tie resistor merging, and additional equivalent pin definitions. Feedback focuses on reliability and performance improvements in the new LVS script: specifically, comparing net names instead of comparing net wrapper objects directly with != to avoid KLayout wrapper identity issues, and using any? instead of to_a on iterators to prevent unnecessary memory allocations.
Contributor
Author
|
addresses #4466 |
code review feedback Signed-off-by: Jeff Ng <jeffng@precisioninno.com>
openroad-ci
force-pushed
the
sky130hd-lvs-fix
branch
from
September 5, 2026 03:59
96014dd to
5eebdc0
Compare
Member
🔍 QoR checkMetrics reflect the PR merge build — i.e. what will land on the target branch. Advisory — results are log-only and do not affect build status. The authoritative QoR gate remains the local rules-file check. Commit 62 design(s) checked — 0 with regression(s), 0 without a comparable baseline.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
aes, gcd, ibex, jpeg, and riscv32i all pass now. The other two have memories without CDL netlists.