flow: update MPL and designs configs - #4493
Open
joaomai wants to merge 3 commits into
Open
Conversation
Signed-off-by: João Mai <jmai@precisioninno.com>
Signed-off-by: João Mai <jmai@precisioninno.com>
Signed-off-by: João Mai <jmai@precisioninno.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request replaces the deprecated MACRO_PLACE_HALO and MACRO_BLOCKAGE_HALO configuration variables with RTLMP_MIN_CHANNEL_SIZE and RTLMP_PIN_AWARE_CHANNELS. It updates the documentation, variable definitions, design/platform configuration files, and the macro placement utility script accordingly. Additionally, the OpenROAD submodule has been updated to a newer commit. There are no review comments, so I have no feedback to provide.
Member
🔍 QoR checkMetrics reflect the PR merge build — i.e. what will land on the target branch. Advisory — results are log-only and do not affect build status. The authoritative QoR gate remains the local rules-file check. Commit 63 design(s) checked — 4 with regression(s), 6 without a comparable baseline.
❌ gf180/uart-blocks base — 1 failing metric(s)
❌ nangate45/bp_multi_top base — 1 failing metric(s)
❌ nangate45/mempool_group base — 3 failing metric(s)
❌ sky130hd/chameleon base — 2 failing metric(s)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates ORFS to accommodate the changes introduced in #11292 from OR.
RTLMP_MIN_CHANNEL_SIZEtakes the place ofMACRO_PLACE_HALO, and the usage of pin-awareness in MPL is now a flag:RTLMP_PIN_AWARE_CHANNELSis set to 1 by default if RTLMP_MIN_CHANNEL_SIZE is also set, otherwise it is set to 0.No metrics change.