Tighten design - #4485
Open
rafaelmoresco wants to merge 1 commit into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request increases the core utilization to 80 and tightens the clock period from 7.5ns to 6.0ns for the jpeg design on the gf180 platform, updating the baseline rules to match. However, the review points out a critical issue where the worst setup slack (finish__timing__setup__ws) has degraded to -0.523, meaning the design fails to meet timing under the new clock period. Codifying this negative slack in the baseline rules allows timing-failing designs to pass CI.
Member
🔍 QoR checkMetrics reflect the PR merge build — i.e. what will land on the target branch. Advisory — results are log-only and do not affect build status. The authoritative QoR gate remains the local rules-file check. Commit 62 design(s) checked — 0 with regression(s), 0 without a comparable baseline.
|
openroad-ci
force-pushed
the
update-metrics-rafael
branch
from
September 3, 2026 21:52
394ddbb to
7ad95f8
Compare
Member
|
@rafaelmoresco Could you merge latest master to ensure your changes to the design still work? |
Signed-off-by: rafaelmoresco <rafaelmorescovieira@gmail.com>
openroad-ci
force-pushed
the
update-metrics-rafael
branch
from
September 4, 2026 18:26
7ad95f8 to
717baaa
Compare
Author
|
@eder-matheus rebased on master, continues with negative slack. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gf180 Jpeg
Core utilization: 45 => 80
Clock period: 7.5 => 6.0