-
Notifications
You must be signed in to change notification settings - Fork 523
Tighten designs #4482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Tighten designs #4482
Changes from all commits
f8a252f
b6fa2ef
a489436
377fc7e
262afba
0547ebb
5f4b324
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| set clk_name core_clock | ||
| set clk_port_name clock | ||
| set clk_period 800 | ||
| set clk_period 700 | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Does it change QoR at all? I don't see new metrics for this design. |
||
| set clk_io_pct 0.2 | ||
|
|
||
| set clk_port [get_ports $clk_port_name] | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,23 +18,23 @@ | |
| "compare": "==" | ||
| }, | ||
| "placeopt__design__instance__area": { | ||
| "value": 725567, | ||
| "value": 724846, | ||
| "compare": "<=" | ||
| }, | ||
| "placeopt__design__instance__count__stdcell": { | ||
| "value": 15783, | ||
| "value": 15301, | ||
| "compare": "<=" | ||
| }, | ||
| "detailedplace__design__violations": { | ||
| "value": 0, | ||
| "compare": "==" | ||
| }, | ||
| "cts__design__instance__count__setup_buffer": { | ||
| "value": 1372, | ||
| "value": 1330, | ||
| "compare": "<=" | ||
| }, | ||
| "cts__design__instance__count__hold_buffer": { | ||
| "value": 1372, | ||
| "value": 1330, | ||
| "compare": "<=" | ||
| }, | ||
| "cts__timing__setup__ws": { | ||
|
|
@@ -62,7 +62,7 @@ | |
| "compare": ">=" | ||
| }, | ||
| "globalroute__timing__setup__tns": { | ||
| "value": -2.0, | ||
| "value": -8.23, | ||
| "compare": ">=" | ||
| }, | ||
| "globalroute__timing__hold__ws": { | ||
|
|
@@ -94,7 +94,7 @@ | |
| "compare": ">=" | ||
| }, | ||
| "finish__timing__setup__tns": { | ||
| "value": -2.07, | ||
| "value": -31.7, | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The total negative slack ( |
||
| "compare": ">=" | ||
| }, | ||
| "finish__timing__hold__ws": { | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,7 +5,7 @@ export PLATFORM = ihp-sg13g2 | |
| export VERILOG_FILES = $(sort $(wildcard $(DESIGN_HOME)/src/$(DESIGN_NICKNAME)/*.v)) | ||
| export SDC_FILE = $(DESIGN_HOME)/$(PLATFORM)/$(DESIGN_NICKNAME)/constraint.sdc | ||
|
|
||
| export CORE_UTILIZATION = 20 | ||
| export CORE_UTILIZATION = 85 | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Setting |
||
| export CORE_ASPECT_RATIO = 1 | ||
|
|
||
| export PLACE_DENSITY = 0.65 | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,31 +10,31 @@ | |
| "level": "warning" | ||
| }, | ||
| "synth__design__instance__area__stdcell": { | ||
| "value": 140000.0, | ||
| "value": 139000.0, | ||
| "compare": "<=" | ||
| }, | ||
| "constraints__clocks__count": { | ||
| "value": 2, | ||
| "compare": "==" | ||
| }, | ||
| "placeopt__design__instance__area": { | ||
| "value": 157813, | ||
| "value": 156855, | ||
| "compare": "<=" | ||
| }, | ||
| "placeopt__design__instance__count__stdcell": { | ||
| "value": 10692, | ||
| "value": 10640, | ||
| "compare": "<=" | ||
| }, | ||
| "detailedplace__design__violations": { | ||
| "value": 0, | ||
| "compare": "==" | ||
| }, | ||
| "cts__design__instance__count__setup_buffer": { | ||
| "value": 930, | ||
| "value": 925, | ||
| "compare": "<=" | ||
| }, | ||
| "cts__design__instance__count__hold_buffer": { | ||
| "value": 930, | ||
| "value": 925, | ||
| "compare": "<=" | ||
| }, | ||
| "cts__timing__setup__ws": { | ||
|
|
@@ -74,7 +74,7 @@ | |
| "compare": ">=" | ||
| }, | ||
| "detailedroute__route__wirelength": { | ||
| "value": 456338, | ||
| "value": 575080, | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The detailed routing wirelength ( |
||
| "compare": "<=" | ||
| }, | ||
| "detailedroute__route__drc_errors": { | ||
|
|
@@ -106,7 +106,7 @@ | |
| "compare": ">=" | ||
| }, | ||
| "finish__design__instance__area": { | ||
| "value": 168206, | ||
| "value": 167407, | ||
| "compare": "<=" | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,15 +16,15 @@ export ADDITIONAL_LIBS = $(PLATFORM_DIR)/lib/fakeram45_512x64.lib \ | |
| $(PLATFORM_DIR)/lib/fakeram45_64x7.lib \ | ||
| $(PLATFORM_DIR)/lib/fakeram45_64x96.lib | ||
|
|
||
| export DIE_AREA = 0 0 800 600 | ||
| export CORE_AREA = 10 10 790 590 | ||
|
|
||
| export CORE_UTILIZATION = 50 | ||
| export PLACE_DENSITY_LB_ADDON = 0.11 | ||
|
Comment on lines
+20
to
+21
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Removing the fixed |
||
|
|
||
| export IO_CONSTRAINTS = $(DESIGN_HOME)/$(PLATFORM)/$(DESIGN_NAME)/io.tcl | ||
|
|
||
|
|
||
| export MACRO_PLACE_HALO = 10 10 | ||
|
|
||
| export PLACE_DENSITY_LB_ADDON = 0.11 | ||
| export TNS_END_PERCENT = 100 | ||
|
|
||
| export FASTROUTE_TCL = $(DESIGN_HOME)/$(PLATFORM)/$(DESIGN_NAME)/fastroute.tcl | ||
|
|
||
| +1 −0 | .bazelrc | |
| +4 −2 | MODULE.bazel | |
| +3,437 −3,469 | MODULE.bazel.lock | |
| +2 −0 | test/downstream/.bazelrc | |
| +4 −1 | test/downstream/MODULE.bazel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using dynamic
CORE_UTILIZATIONinstead of fixedDIE_AREAandCORE_AREAis highly risky for designs containing macros (such as the SRAMs specified inWRAP_LEFS). In physical design flows, dynamic floorplan sizing based on standard cell area changes the die boundaries whenever the netlist size fluctuates. This will break manual macro placement configurations that rely on absolute coordinates, leading to placement failures or overlaps. It is recommended to retain fixedDIE_AREAandCORE_AREAdimensions for designs with macros to ensure stability.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this true @eder-matheus ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm pretty sure we have other designs with macros that uses CORE_UTILIZATION. You can double check it, but I think this is just gemini hallucinating.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AcKoucher @joaomai what do you say?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your changes are fine. If a certain design were to use manual macro placement we could treat it as an exception. It's just Gemini being overly defensive.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks guys!