Fix TextArea scrollbar initial wrap flicker (#5103)#6499
Draft
glaziermag wants to merge 1 commit intoTextualize:mainfrom
Draft
Fix TextArea scrollbar initial wrap flicker (#5103)#6499glaziermag wants to merge 1 commit intoTextualize:mainfrom
glaziermag wants to merge 1 commit intoTextualize:mainfrom
Conversation
This commit forces an internal geometry double-pass exclusively during _rewrap_and_refresh_virtual_size if the wrap calculation triggers an appearance/disappearance of the scrollbar, mathematical locking the width instead of allowing an async render flush flicker.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix TextArea scrollbar initial wrap flicker (#5103)
This commit forces an internal geometry double-pass exclusively during
_rewrap_and_refresh_virtual_sizeif the wrap calculation triggers an appearance/disappearance of the scrollbar dynamically. This mathematically sets the width before flushing the virtual DOM to the visual layer, preventing the flicker loop reported in #5103.The Epistemic Before vs After Logs
Input Command:
Before Logs:
Notice how the layout unpredictably triggers events during
resizepushing to an async queue and bouncing between15and13.After Logs:
The geometry natively stabilizes in memory perfectly inside the bounding box before being rendered.
302 Pytest assertions passed locally in 33.49s ensuring no downstream caching regressions.