Fix console.print() with empty args to respect end parameter#3962
Closed
veeceey wants to merge 1 commit intoTextualize:masterfrom
Closed
Fix console.print() with empty args to respect end parameter#3962veeceey wants to merge 1 commit intoTextualize:masterfrom
veeceey wants to merge 1 commit intoTextualize:masterfrom
Conversation
When console.print() was called with no arguments but a custom end parameter, it would print a newline instead of the end character. This was because empty objects were replaced with NewLine() regardless of the end parameter. Fixed by only using NewLine() when end is the default "\n", otherwise use an empty Text object that will properly render with the custom end character. Fixes Textualize#3701
Author
|
Code changes verified ✓ Mergeable: YES | Ready for maintainer review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3701
When
console.print()was called with no arguments but a customendparameter, it would print a newline instead of the end character. This was because empty objects were always replaced withNewLine()regardless of theendparameter.Changes
Console.print()inrich/console.pyto only useNewLine()whenendis the default"\n"endis a custom value, use an emptyTextobject that will properly render with the custom end charactertest_print_empty_with_end()to verify the fixTest plan
print()Before
After