Skip to content

Power Management: Add LPM Documentation for J7200 and J784S4 #566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gehariprasath merged 1 commit into from
Dec 16, 2025
Merged

Power Management: Add LPM Documentation for J7200 and J784S4 #566

gehariprasath merged 1 commit into from
Dec 16, 2025
+150 −0

Conversation

@PrasanthBabuMantena
Copy link

@PrasanthBabuMantena PrasanthBabuMantena commented Dec 9, 2025

J7200 and J784S4 supports two low poer modes, SOC_OFF and IO_ONLY_PLUS_DDR. Add related documentation for the modes supported and their usage details.

@github-actions
Copy link

github-actions bot commented Dec 9, 2025

New warnings found with rstcheck:

source/linux/Foundational_Components/Power_Management/pm_low_power_modes_socoff.rst:59: (WARNING/2) Title overline too short.
source/linux/Foundational_Components/Power_Management/pm_low_power_modes_socoff.rst:59: (WARNING/2) Title overline too short.

@uditkumarti
Copy link
Collaborator

uditkumarti commented Dec 9, 2025

New warnings found with rstcheck:

source/linux/Foundational_Components/Power_Management/pm_low_power_modes_socoff.rst:59: (WARNING/2) Title overline too short.
source/linux/Foundational_Components/Power_Management/pm_low_power_modes_socoff.rst:59: (WARNING/2) Title overline too short.

@PrasanthBabuMantena Please take care of bot warnings

cshilwant
cshilwant requested changes Dec 9, 2025
View reviewed changes
Copy link
Member

@cshilwant cshilwant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are few warnings reported by vale which needs to be addressed
checkout https://github.com/TexasInstruments/processor-sdk-doc/pull/566/files

uditkumarti
uditkumarti requested changes Dec 9, 2025
View reviewed changes
Copy link
Collaborator

@uditkumarti uditkumarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$subject should start with feat or something,
Please do git log to see format

StaticRocket
StaticRocket requested changes Dec 10, 2025
View reviewed changes
@github-actions
Copy link

github-actions bot commented Dec 10, 2025

New warnings found with rstcheck:

source/linux/Foundational_Components_Multimedia_wave5.rst:740: (INFO/1) Duplicate implicit target name: "example commands".
source/linux/Foundational_Components_Multimedia_wave5.rst:823: (ERROR/3) Error in "code-block" directive:
source/linux/Foundational_Components_Multimedia_wave5.rst:835: (ERROR/3) Error in "code-block" directive:

StaticRocket
StaticRocket requested changes Dec 10, 2025
View reviewed changes
@StaticRocket
Copy link
Member

StaticRocket commented Dec 10, 2025

Also some vale warnings about passive voice

StaticRocket
StaticRocket previously approved these changes Dec 13, 2025
View reviewed changes
@StaticRocket
Copy link
Member

StaticRocket commented Dec 13, 2025

@StaticRocket @cshilwant , only one vale error is that it asks to expand DDR to Double data* in the first reference. Is it required really ?

Nah, I've been fairly lax on acronyms unless they are domain specific. It's the passive voice and simplified language I'm more concerned about. There are still warnings about passive voice.

@StaticRocket StaticRocket self-requested a review December 13, 2025 00:48
kwillis01
kwillis01 suggested changes Dec 13, 2025
View reviewed changes
Copy link
Contributor

@kwillis01 kwillis01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it could be good to add a comparison table of SoC off and I/O Only + DDR LPMs so that customers can easily see the differences. Table could include which has better power consumption, resume latency, how it resumes, etc.

@PrasanthBabuMantena
Copy link
Author

PrasanthBabuMantena commented Dec 15, 2025

@StaticRocket All the passive to active voice conversions have been made and I dont see any warning on that pov now on vale.

@PrasanthBabuMantena
Copy link
Author

PrasanthBabuMantena commented Dec 15, 2025

Please approve this PR if you don't have any further comments.

uditkumarti
uditkumarti reviewed Dec 15, 2025
View reviewed changes
Copy link
Collaborator

@uditkumarti uditkumarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks ok. Please address vale warning

uditkumarti
uditkumarti previously approved these changes Dec 15, 2025
View reviewed changes
gehariprasath
gehariprasath previously approved these changes Dec 15, 2025
View reviewed changes
Copy link
Collaborator

@gehariprasath gehariprasath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing my comments

cshilwant
cshilwant previously approved these changes Dec 15, 2025
View reviewed changes
@p-mantena
feat(pm_low_power_modes_socoff): Add LPM Documentation for J7200 and …
51781eb 
…J784S4

J7200 and J784S4 supports two low poer modes, SOC_OFF and IO_ONLY_PLUS_DDR.
Add related documentation for the modes supported and their usage details.

Signed-off-by: Prasanth Babu Mantena <p-mantena@ti.com>
@gehariprasath gehariprasath merged commit d97872a into TexasInstruments:master Dec 16, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StaticRocket StaticRocket StaticRocket approved these changes

@uditkumarti uditkumarti uditkumarti approved these changes

@gehariprasath gehariprasath gehariprasath left review comments

@cshilwant cshilwant cshilwant left review comments

@praneethbajjuri praneethbajjuri Awaiting requested review from praneethbajjuri praneethbajjuri is a code owner

@VeeruPrudhvi VeeruPrudhvi Awaiting requested review from VeeruPrudhvi VeeruPrudhvi is a code owner

@jeevantelukula jeevantelukula Awaiting requested review from jeevantelukula jeevantelukula is a code owner

@devarsht devarsht Awaiting requested review from devarsht

@DhruvaG2000 DhruvaG2000 Awaiting requested review from DhruvaG2000

@r-vignesh r-vignesh Awaiting requested review from r-vignesh

@vishalmti vishalmti Awaiting requested review from vishalmti

@kwillis01 kwillis01 Awaiting requested review from kwillis01

Assignees

@praneethbajjuri praneethbajjuri

@devarsht devarsht

@r-vignesh r-vignesh

@gehariprasath gehariprasath

@DhruvaG2000 DhruvaG2000

@uditkumarti uditkumarti

@vishalmti vishalmti

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.