-
Notifications
You must be signed in to change notification settings - Fork 76
feat(AM335X): Add webserver demo user guide #542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(AM335X): Add webserver demo user guide #542
Conversation
cshilwant
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some warnings from vales could also be looked into
0470f37 to
ec79299
Compare
|
New warnings found with rstcheck: |
ec79299 to
d7800ee
Compare
cshilwant
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#542 (comment) needs to be addressed
d7800ee to
d1000b8
Compare
cshilwant
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for handling the suggestions. The v2 is in much better shape.
There are couple of minor fixes needed, post which the PR is good to go
d1000b8 to
29e05e9
Compare
|
Updated the PR according to the review comments |
StaticRocket
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm mostly fine with this. The image sizes, while being rather large are still under the current mean size. I just fear that the scaled versions will still be hard to see considering the amount of dead space. Feel free to update this if you agree.
Add the documentation for the new Webserver Demo added showcasing the audio analytics and performance stats. Signed-off-by: Telukula Jeevan Kumar Sahu <j-sahu@ti.com>
29e05e9 to
2bf9a58
Compare
@StaticRocket I wanted to show the complete view of the webpage. However, I have reduced the size of the images by around 50 percent, keeping the view same. |
Add the documentation for the new Webserver Demo added showcasing the audio analytics and performance stats.