Refactor/relacement names #516
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All platforms currently use __PART_FAMILY_NAME__ to point at an explicit device name. Update this platform to match. Signed-off-by: Randolph Sapp <rs@ti.com>
Replace all instances of __PART_FAMILY_DEVICE_NAMES__ with __PART_FAMILY_NAME__ since the two are equivalent. Signed-off-by: Randolph Sapp <rs@ti.com>
Remove the __PART_FAMILY_DEVICE_NAMES__ replacement definition since it is no longer used. Signed-off-by: Randolph Sapp <rs@ti.com>
github-actions
bot
assigned
3V3RYONE,
aniket-l,
bryanbrattlof,
devarsht,
DhruvaG2000,
glaroque,
jmenti,
makohoek,
praneethbajjuri and
r-vignesh
StaticRocket
requested review from
VeeruPrudhvi,
aniket-l,
cshilwant,
praneethbajjuri and
uditkumarti
as code owners
jmenti
reviewed
Dec 1, 2025
Collaborator
jmenti
left a comment
jmenti
left a comment
There was a problem hiding this comment.
Making sure there is no bug in the variable you are modifying, but other than that, this looks good to me
| ------------ | ||
|
|
||
| In today's fast-paced automotive industry, the ability to achieve quick processor boot times is more crucial than ever. This guide will walk you through the necessary steps and considerations for achieving faster boot times on |__PRODUCT_LINE_NAME__| |__PART_FAMILY_DEVICE_NAMES__| devices. From adjusting configurations to implementing best practices, you'll gain the insights needed to deliver a seamless, responsive user experience in your automotive applications. By implementing specific modifications, the default SDK offering can be optimized to boot much faster. | ||
| In today's fast-paced automotive industry, the ability to achieve quick processor boot times is more crucial than ever. This guide will walk you through the necessary steps and considerations for achieving faster boot times on |__PRODUCT_LINE_NAME__| |__PART_FAMILY_NAME__| devices. From adjusting configurations to implementing best practices, you'll gain the insights needed to deliver a seamless, responsive user experience in your automotive applications. By implementing specific modifications, the default SDK offering can be optimized to boot much faster. |
Member
Author
There was a problem hiding this comment.
Why do you think this is a bug?
Collaborator
There was a problem hiding this comment.
I am not sure if the diff here is tricking me, but:
considerations for achieving faster boot times on |PRODUCT_LINE_NAME| |
PART_FAMILY_NAME|
is the second variable missing the leading pipe?
| | Range 2 (MCU_PORz to SBL_start): | ||
| | MCU_PORz is the Power-On-Reset pin that is set HIGH as soon as the PMIC powers the voltage rails. This can be probed using Pin #28 on the MCU Header (J11) of the |__PART_FAMILY_DEVICE_NAMES__|. All pins are automatically set HIGH at this point. | ||
| | MCU_PORz is the Power-On-Reset pin that is set HIGH as soon as the PMIC powers the voltage rails. This can be probed using Pin #28 on the MCU Header (J11) of the |__PART_FAMILY_NAME__|. All pins are automatically set HIGH at this point. |
jmenti
approved these changes
Dec 1, 2025
jmenti
approved these changes
Dec 1, 2025
Member
Author
|
Marking this as blocked until the current release's influx of PRs has settled down. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor(names): remove PART_FAMILY_DEVICE_NAMES
Remove the PART_FAMILY_DEVICE_NAMES replacement definition since it is no
longer used.
Signed-off-by: Randolph Sapp rs@ti.com
refactor(names): use shorter replacement name
Replace all instances of PART_FAMILY_DEVICE_NAMES with
PART_FAMILY_NAME since the two are equivalent.
Signed-off-by: Randolph Sapp rs@ti.com
fix(TDA4VM): set PART_FAMILY_NAME to device
All platforms currently use PART_FAMILY_NAME to point at an explicit
device name. Update this platform to match.
Signed-off-by: Randolph Sapp rs@ti.com
Opening as a draft for now as there are other cleanup efforts I assume will clash with this currently.