coverage: add tolerance to Stopwatch test#947
Merged
Conversation
vbreuss
added
the
coverage
vbreuss
changed the title
Stopwatch testStopwatch test
There was a problem hiding this comment.
Pull request overview
This PR attempts to make the Stop_ShouldSetIsRunningToFalse test less brittle by adding tolerance for potential rounding issues on the real file system. The change reduces the expected minimum elapsed time from 100ms to 99ms (a 1ms tolerance) and adds an explanatory comment.
Changes:
- Modified timing assertion in
Stop_ShouldSetIsRunningToFalsetest to use 99ms threshold instead of 100ms to account for rounding
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR attempts to make the
Stop_ShouldSetIsRunningToFalsetest less brittle by adding tolerance for potential rounding issues on the real file system. The change reduces the expected minimum elapsed time from 100ms to 99ms (a 1ms tolerance) and adds an explanatory comment.