DnsWebService: add DNS_SERVER_WEB_SERVICE_WWW_FOLDER_PATH to configure the web root folder - #2138
Open
byGarcia wants to merge 2 commits into
Open
Conversation
…ironment variable to allow overriding the web service web root folder. Falls back to the default folder when the variable is unset or when the configured folder does not exist so that the server always starts.
…_FOLDER_PATH environment variable. Added a note since, unlike the other variables, it is not stored in the DNS config file and is therefore read on every start.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The web root is fixed at
wwwnext toDnsServerApp.dll, so anything that replaces the web console is lost on the next update: the installer extracts the release over the installation folder and puts its ownwwwback.This adds an environment variable to point the web service at a different folder, so a replaced console can live outside the installation folder and survive updates.
What it does
DNS_SERVER_WEB_SERVICE_WWW_FOLDER_PATHoverrides the web root folder.<app folder>/wwwis used, exactly as before.DockerEnvironmentVariables.md, with a note — unlike the other variables listed there, this one is not stored in the DNS config file, so it is read on every start rather than only on the first one.Two files, 15 lines added. No API change, no config file change, and no behaviour change at all when the variable is not set.
Verified
Built from this branch —
DnsServerApppublished and an image built with the repository's ownDockerfile— and run:Context
This is the piece that the installable alternative GUI you suggested in #2128 needs. With it, installing one does not mean overwriting
www, and a server update does not silently restore the stock console on top of it.I agree to the copyright and IPR transfer set out in
CONTRIBUTING.mdfor this contribution.