Reduce allocations in concurrent forwarder selection#2061
Open
zs311521 wants to merge 1 commit into
Open
Conversation
Member
|
Thanks for the PR. Will evaluate this soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is deliberately separate from #2060: it is a hot-path allocation optimization, not a statistics-retention fix.
Why
The global forwarding path currently allocates
newForwardersandresolveTasksfor every concurrent resolution, even when the configured endpoints are already resolved. That is the common case for long-running forwarders, including concurrent DNS-over-QUIC upstream configurations.The candidate takes one typed array snapshot first, preserving per-query membership, source order, duplicates, and object identity. It scans that snapshot for stale endpoints. Fresh snapshots pass directly to the existing
DnsClientpath; if any endpoint is stale—or the configuration is empty—the stock resolution/error path runs with the snapshot.Proxy and sequential branches are untouched.
Allocation measurement
Release, .NET SDK 10.0.302, selection fragment only (before
DnsClient):For the ordinary two-forwarder case this removes 136 B/op from this fragment. It is not presented as a percentage reduction for the whole resolver request.
Verification
git diff --checkpassesThe stale case pays for the initial snapshot before entering the unchanged resolution path. That small rare-path cost is the tradeoff for a single source observation and stable per-query membership.